Ruby on Rails function not working as expected

Question

So I wrote this in my controller on a RoR app.

class KalendarController < ApplicationController

  def show
    @week =
    if Date.today.cweek % 2 == 0
      puts "E"
    else
      puts "O"
    end
  end
end

the @week variable should hold "E" or "N" depending on the result of Date.today.cweek % 2 == 0 so that I can display the letter "N" or "P" in the View

which looks something like this:

<h1>Kalendar#show</h1>
<p>Find me in app/views/kalendar/show.html.erb</p>


<p><%= @week %>

But this is not working. Can someone please point out what I'm doing wrong?

Alex Wayne · Accepted Answer · 2013-12-10 01:22:56Z

2

puts prints the string out the command line, but returns nil. So both branches of your if statement were returning return nil, and @week was set to nil.

So remove the puts and your good.

@week =
  if Date.today.cweek % 2 == 0
    "E"
  else
    "O"
  end

answered Dec 10, 2013 at 1:22

Alex Wayne

188k52 gold badges328 silver badges363 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

jstim Over a year ago

you could do it in a single line as well with @week = Date.today.cweek % 2 == 0 ? "E" : "O"

Mark Thomas · Accepted Answer · 2013-12-10 02:50:51Z

1

You don't need modulus--you can use the even? method.

@week = Date.today.cweek.even? ? "E" : "O"

edited Dec 10, 2013 at 2:50

answered Dec 10, 2013 at 2:43

Mark Thomas

37.6k11 gold badges78 silver badges101 bronze badges

2 Comments

lulalala Over a year ago

@week = Date.today.cweek.even? ? "E" : "O"

Mark Thomas Over a year ago

Had a typo, sorry. Try it now.

Collectives™ on Stack Overflow

Ruby on Rails function not working as expected

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related