Cant pass value as variable in this php script

Question

Like the question says, I can't seem to pass a value in a variable in the following script. If I echo the variable, it exists as expected. If i copy and paste the echoed value into the code where $my_var is, it works. But it wont work with $my_var ?!?!?

Context- code requires another file to create a pdf, attaches it to an email and sends it, and then displays it in the browser. Have removed most of the code for brevity

$my_var = $_POST['quote_number'];
$filename = 'Quote_no' . $my_var . '.pdf';
$file = $_SERVER['DOCUMENT_ROOT'] . '/quotes/' . $filename ;
require('instant_quote.php');
function send_quote($my_var) {
     //my_function code
   };
send_quote($my_var);
header('Content-type: application/pdf');
header('Content-Disposition: inline; filename="' . $filename . '"');
header('Content-Transfer-Encoding: binary');
header('Content-Length: ' . filesize($file));
header('Accept-Ranges: bytes');
@readfile($file);

Tried taking that out, still doesn't work

Talk nerdy to me
– Talk nerdy to me

2013-12-12 04:35:44 +00:00
Commented Dec 12, 2013 at 4:35 — Talk nerdy to me
– Talk nerdy to me, Commented Dec 12, 2013 at 4:35

scrowler · Accepted Answer · 2013-12-12 04:36:25Z

1

The syntax highlighting in your example was helpful, you have incorrect matching quotes:

$filename = "Quote_no' . $my_var . '.pdf";

... should be:

$filename = 'Quote_no' . $my_var . '.pdf';

answered Dec 12, 2013 at 4:36

scrowler

24.4k10 gold badges67 silver badges99 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

Talk nerdy to me Over a year ago

Sorry, that was a mistake when I retyped the code, it's not in my actual code- edited to show

scrowler Over a year ago

@Imaginate I can't see any difference in your question code, but have you tried var_dump($_POST) to make sure your value is actually there and doesn't contain anything you don't expect (e.g. whitespace on either end)?

Talk nerdy to me Over a year ago

Contents of var dump -

array(11) { ["name"]=> string(0) "" ["company_name"]=> string(0) "" ["design_level"]=> string(5) "basic" ["address"]=> string(0) "" ["email"]=> string(0) "" ["content"]=> string(4) "none" ["type"]=> string(7) "Landing" ["size"]=> string(11) "single page" ["product_qty"]=> string(4) "< 30" ["action"]=> string(13) "instant_quote" ["quote_number"]=> string(5) "W1741" }

scrowler Over a year ago

Looks fine, go through and var_dump every variable or function call in your script until you find something you weren't expecting

Nikhil Kudtarkar Over a year ago

Use $_POST['quote_number'] instead of $my_var then :p

|

Talk nerdy to me · Accepted Answer · 2013-12-12 08:14:50Z

1

Don't know why this worked, but it did...

header('Content-type: application/pdf');
header('Content-Disposition: inline; filename="' . $file . '"');
header('Content-Length: ' . filesize($filename));
@readfile($filename);

Just removed the transfer encoding and accept-ranges from the headers, and it started accepting my variable as a value... go figure

answered Dec 12, 2013 at 8:14

Talk nerdy to me

1,0859 silver badges11 bronze badges

1 Comment

scrowler Over a year ago

interesting... there must be some conflict between posted data and those headers being sent... +1 for working it out yourself

Collectives™ on Stack Overflow

Cant pass value as variable in this php script

2 Answers 2

10 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related