Html with javascript in php seems to be conflicting

Question

The code i want to get into a php statement is

<a href="javascript:void();"
   onclick="document.loginfrm.user.value="username";
   document.loginfrm.pass.value="password";
   document.loginfrm.submit();">login
</a>

So what i would normally do is just surround it with an echo and quotation marks: an then replace any quotation marks in the statement with these --> ('), so that's what i did... and for some reason it seems to misinterpret the sentence severely. Here is the code i enter in php.

   echo "<a href='javascript:void();'
   onclick='document.loginfrm.user.value='username';
   document.loginfrm.pass.value='password';
   document.loginfrm.submit();'>". login ."</a>";

And this is how the browser interprets it:

    <a href="javascript:void();
" onclick="document.loginfrm.user.value=" username';="" 
document.loginfrm.pass.value="password" ;="" document.loginfrm.submit();'="">
login</a>

So yes is there any way around displaying html within php that could get around this problem

Krish R · Accepted Answer · 2013-12-18 05:35:52Z

1

Can you try this, added \

    echo "<a href=\"javascript:void();\"
       onclick=\"document.loginfrm.user.value='username';
       document.loginfrm.pass.value=password';
       document.loginfrm.submit();\">login </a>";

answered Dec 18, 2013 at 5:35

Krish R

22.7k7 gold badges54 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Konsole · Accepted Answer · 2013-12-18 05:35:21Z

1

You need to escape it properly. Try

echo "<a href=\"javascript:void();\"
   onclick=\"document.loginfrm.user.value='username';
   document.loginfrm.pass.value='password';
   document.loginfrm.submit();\">". $login ."</a>";

answered Dec 18, 2013 at 5:35

Konsole

3,4753 gold badges31 silver badges41 bronze badges

Comments

Alconja · Accepted Answer · 2013-12-18 05:37:13Z

1

You're not escaping your quotes. Try:

echo "<a href=\"javascript:void();\"
onclick=\"document.loginfrm.user.value='username';
document.loginfrm.pass.value='password';
document.loginfrm.submit();\">". login ."</a>";

which should produce:

<a href="javascript:void();"
   onclick="document.loginfrm.user.value='username';
   document.loginfrm.pass.value='password';
   document.loginfrm.submit();">login
</a>

As you have it now, you're closing the onclick attribute when you hit the quote at the start of the "username" value, which means the browser is interpreting username as another attribute and it just gets more confused from there...

_{Edit: sorry, fixed the html, rather than the php code...}

edited Dec 18, 2013 at 5:37

answered Dec 18, 2013 at 5:31

Alconja

14.9k3 gold badges62 silver badges61 bronze badges

Comments

zzlalani · Accepted Answer · 2013-12-18 05:37:01Z

0

You should do something like this..

<a href="javascript:void();"
   onclick="document.loginfrm.user.value='username';
   document.loginfrm.pass.value='password';
   document.loginfrm.submit();">login
</a>

and with php it should be

echo '<a href="javascript:void();"
          onclick="document.loginfrm.user.value=\"username\";
          document.loginfrm.pass.value=\"password\";
          document.loginfrm.submit();">
          login
      </a>';

answered Dec 18, 2013 at 5:37

zzlalani

24.6k16 gold badges48 silver badges73 bronze badges

Collectives™ on Stack Overflow

Html with javascript in php seems to be conflicting

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related