file uploading and creating upload folders with Codeigniter

Question

I'm having this function inside my Album_Model:

public function upload($album_id, $album){
        $album= strtolower($album);

        $upload_config = array(
            'upload_path'   =>  './uploads/'.$album,
            'allowed_types' =>  'jpg|jpeg|gif|png',
            'max_size'      =>  '2000',
            'max_width'     =>  '680',
            'max_height'    =>  '435', 
        );

        $this->load->library('upload', $upload_config);

        // create an album if not already exist in uploads dir
// wouldn't make more sence if this part is done if there are no errors and right before the upload ??
        if (!is_dir('uploads')) {
            mkdir('./uploads', 0777, true);
        }
        if (!is_dir('uploads/'.$album)) {
            mkdir('./uploads/'.$album, 0777, true);
        }

        if (!$this->upload->do_upload('imgfile')) { 
            // upload failed
            return array('error' => $this->upload->display_errors('<span>', '</span>'));
        } else {
            // upload success
            $upload_data = $this->upload->data();
            return true;
        }
    }

So what this basicly does is to upload images to an album. Also if the folder album does not exist already, it creates a new album.

I was doing some tests and found out something that might be a small bug. While I was forcing my form to do some invalid upload attempts and the upload fails, as expected, but the album folder (suppose the album folder doesn't exist) is still created.

Whouldn't make more sence to create the album folder if there are no erros and right before uploading the image and if yes how can I fix this??

Kumar V · Accepted Answer · 2013-12-18 08:19:25Z

6

You have set a flag for checking the directory existence. I have changed your code to make it work as per your need.

<?php

public function upload($album_id, $album)
{
    $album = strtolower($album);

    $upload_config = array('upload_path' => './uploads/' . $album, 'allowed_types' =>
        'jpg|jpeg|gif|png', 'max_size' => '2000', 'max_width' => '680', 'max_height' =>
        '435', );

    $this->load->library('upload', $upload_config);

    // create an album if not already exist in uploads dir
    // wouldn't make more sence if this part is done if there are no errors and right before the upload ??
    if (!is_dir('uploads'))
    {
        mkdir('./uploads', 0777, true);
    }
    $dir_exist = true; // flag for checking the directory exist or not
    if (!is_dir('uploads/' . $album))
    {
        mkdir('./uploads/' . $album, 0777, true);
        $dir_exist = false; // dir not exist
    }
    else{

    }

    if (!$this->upload->do_upload('imgfile'))
    {
        // upload failed
        //delete dir if not exist before upload
        if(!$dir_exist)
          rmdir('./uploads/' . $album);

        return array('error' => $this->upload->display_errors('<span>', '</span>'));
    } else
    {
        // upload success
        $upload_data = $this->upload->data();
        return true;
    }
}

?>

edited Dec 18, 2013 at 8:19

answered Dec 18, 2013 at 8:13

Kumar V

8,8289 gold badges44 silver badges60 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

ltdev Over a year ago

Thanks! I didn't believe this would too easy

ltdev Over a year ago

Hey, I've got one more question. suppose I have already an album with some images inside. If I force again an invalid upload wouldn't this delete the album folder with the existing images???

Kumar V Over a year ago

No. I'm setting flag if directory not exist. So if already directory exist, then flag will not set for delete.

Ema4rl · Accepted Answer · 2016-07-27 22:23:59Z

THE ACCEPTED ANSWER IS NOT THE RIGHT WAY!!!

The right way is to extend the Upload library

The code:

<?php
defined('BASEPATH') OR exit('No direct script access allowed');

/**
 * File Uploading Class Extension
 *
 * @package     CodeIgniter
 * @subpackage  Libraries
 * @category    Uploads
 * @author      Harrison Emmanuel (Eharry.me)
 * @link        https://www.eharry.me/blog/post/my-codeigniter-upload-extension/
 */
class MY_Upload extends CI_Upload {

    /**
     * Validate Upload Path
     *
     * Verifies that it is a valid upload path with proper permissions.
     *
     * @return  bool
     */
    public function validate_upload_path()
    {
        if ($this->upload_path === '')
        {
            $this->set_error('upload_no_filepath', 'error');
            return FALSE;
        }

        if (realpath($this->upload_path) !== FALSE)
        {
            $this->upload_path = str_replace('\\', '/', realpath($this->upload_path));
        }

        if ( ! is_dir($this->upload_path))
        {
            // EDIT: make directory and try again
            if ( ! mkdir ($this->upload_path, 0777, TRUE))
            {
                $this->set_error('upload_no_filepath', 'error');
                return FALSE;
            }
        }

        if ( ! is_really_writable($this->upload_path))
        {
            // EDIT: change directory mode
            if ( ! chmod($this->upload_path, 0777))
            {
                $this->set_error('upload_not_writable', 'error');
                return FALSE;
            }
        }

        $this->upload_path = preg_replace('/(.+?)\/*$/', '\\1/',  $this->upload_path);
        return TRUE;
    }
}

How to use:

Simply create application/libraries/MY_Upload.php and paste the code above in it. That's all!

More info:

The GitHub Gist.
My blog post on Eharry.me

NOTE:

This extension is compatible with CodeIgniter 3.x and 2.x versions.

Renier · Accepted Answer · 2013-12-18 08:16:46Z

0

The way you have it it will always make the directory if it does not exist.

To answer your question.. yes, it would make more sense, to create the folder right before uploading.

Try putting this:

if (!is_dir('uploads')) {
    mkdir('./uploads', 0777, true);
        }
if (!is_dir('uploads/'.$album)) {
    mkdir('./uploads/'.$album, 0777, true);
        }

Inside this:

if (!$this->upload->do_upload('imgfile')) { 
        // upload failed
        return array('error' => $this->upload->display_errors('<span>', '</span>'));
    } else {
        // put if statements here.
        // upload success
        $upload_data = $this->upload->data();
        return true;
    }

So it would look like this:

if (!$this->upload->do_upload('imgfile')) { 
        // upload failed
        return array('error' => $this->upload->display_errors('<span>', '</span>'));
    } else {
        if (!is_dir('uploads')) {
        mkdir('./uploads', 0777, true);
    }
    if (!is_dir('uploads/'.$album)) {
        mkdir('./uploads/'.$album, 0777, true);
    }
        // upload success
        $upload_data = $this->upload->data();
        return true;
    }

If I understand you correctly this should do what you want.

Hope it helps.

answered Dec 18, 2013 at 8:16

Renier

1,5454 gold badges34 silver badges63 bronze badges

2 Comments

ltdev Over a year ago

I have already tested this, but didn't work as the path isn't correct. However problem solved! Thanks for your reply anyway.

Renier Over a year ago

Its a pleasure. Glad you got it right. If I know I can answer a question and be of possible help, I always do. Because I know how it feels when no one responds to your question...

Collectives™ on Stack Overflow

file uploading and creating upload folders with Codeigniter

3 Answers 3

3 Comments

THE ACCEPTED ANSWER IS NOT THE RIGHT WAY!!!

The right way is to extend the Upload library

The code:

How to use:

More info:

NOTE:

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

THE ACCEPTED ANSWER IS NOT THE RIGHT WAY!!!

The right way is to extend the Upload library

The code:

How to use:

More info:

NOTE:

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related