JavaScript onclick event fired without any click

Question

I'm trying to clean the URLs of elements and every thing is working, but the onclick event fired directly on the page load but not when I click. How can I fix this?

HTML:

<a class="button" href="http://192.168.1.99:8888/propertyturkey/admin/clients/index/today_calls/?status=3&amp;sales=70&amp;tagged=1&amp;clientName=turkey&amp;nextCall=turkey&amp;clientEmail=sdfgsdfg">Today call list</a>
<input type="reset" class="reset" id="reset" value="Reset">

JS:

var buttons = document.querySelectorAll('.button');
var reset = document.querySelector('.reset');

function forEach(array, action) {
  for (var i = 0; i < array.length; i++) {
    action(array[i])
  };
}

function clear_url_parameters(element) {

  if (!element)
    return false;
  var element_url = element.getAttribute('href');

  var split_url = element_url.split("?");

  var queries = split_url[1].split("&");

  var new_queries = [];

  for (var i = 0; i < queries.length; i++) {
    query = queries[i].split("=");
    new_queries.push(query[0] + "=");
  }

  cleared_url = split_url[0] + new_queries.join('');

  element.setAttribute('href', cleared_url);

}

reset.addEventListener('click', forEach(buttons, clear_url_parameters));

Demo on jsfiddle

Tom Fenech · Accepted Answer · 2013-12-19 11:35:18Z

1

You are passing the result of executing the function forEach to your event listener.

Try this:

reset.addEventListener('click', function () { forEach(buttons, clear_url_parameters); } );

answered Dec 19, 2013 at 11:35

Tom Fenech

75.1k13 gold badges119 silver badges154 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user2666750 · Accepted Answer · 2013-12-19 11:48:29Z

0

change

reset.addEventListener('click', forEach(buttons, clear_url_parameters));

to

reset.addEventListener('click', function(){
    forEach(buttons, clear_url_parameters)
});

Because the parameter you passed to addEventListener has already been called.

edited Dec 19, 2013 at 11:48

answered Dec 19, 2013 at 11:41

user2666750

6021 gold badge8 silver badges11 bronze badges

1 Comment

Ahmad Ajmi Over a year ago

Thanks to your help and explanation, I really appreciate

Collectives™ on Stack Overflow

JavaScript onclick event fired without any click

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related