99

I have a project directory structure as follows (which I think is pretty standard):

my_project
    setup.py
    mypkg
        __init__.py
        foo.py
    tests
        functional
            test_f1.py
        unit
            test_u1.py

I'm using py.test for my testing framework, and I'd expect to be able to run py.test tests when in the my_project directory to run my tests. This does indeed work, until I try to import my application code using (for example) import mypkg in a test. At that point, I get the error "No module named mypkg". On doing a bit of investigation, it appears that py.test runs the tests with the directory of the test file in sys.path, but not the directory that py.test was run from.

In order to work around this, I have added a conftest.py file to my tests directory, containing the following code:

import sys, os

# Make sure that the application source directory (this directory's parent) is
# on sys.path.

here = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
sys.path.insert(0, here)

This seems to work, but is it a good way of making sure that the tests see the application code? Is there a better way of achieving this, or am I doing something wrong in how I have my project structured?

I've looked at some other projects that use py.test (for example, pip) but I can't see code that does anything like this, and yet running py.test tests seems to work there. I don't know quite why, but I'm worried that they may have achieved the same result in a simpler way.

I've looked in the py.test documentation, but I can't see an explanation of this problem or what the recommended approach is to deal with it.

Improve this question
1
  • isn't pytest more readable than py.test? Commented Nov 9, 2022 at 13:35

4 Answers 4

Reset to default
77

As you say yourself py.test basically assumes you have the PYTHONPATH setup up correctly. There are several ways of achieving this:

  • Give your project a setup.py and use pip install -e . in a virtualenv for this project. This is probably the standard method.

  • As a variation on this if you have a virtualenv but no setup.py use your venv's facility to add the projects directory on sys.path, e.g. pew add . if you use pew, or add2virtualenv . if you use virtualenv and the extensions of virtualenvwrapper.

  • If you always like the current working directory on sys.path you can simply always export PYTHONPATH='' in your shell. That is ensure the empty string on on sys.path which python will interpret as the current working direcotry. This is potentially a security hazard though.

  • My own favourite hack, abuse how py.test loads conftest files: put an empty conftest.py in the project's top-level directory.

The reason for py.test to behave this way is to make it easy to run the tests in a tests/ directory of a checkout against an installed package. If it would unconditionally add the project directory to the PYTHONPATH then this would not be possible anymore.

Improve this answer
Sign up to request clarification or add additional context in comments.

12 Comments

Just adding to the first point: if you don't have virtualenv, you can use "python setup.py develop" to the same effect.
the conftest.py hack is a great idea!!! Too bad it's an abuse, IOW it might go away :(
Install something to run tests??? Using more tools just to get a test runner working??? Manipulating Python path, which is never recommended and has to be changed again whenever something is moved in the project??? -- No! Adding an empty file seems like the least hacky solution! I don't know why it works, but I am glad it does. The other options seem just wrong, until someone explains to me why I'd need to install something to test it, when I have all the code in place already.
@Zelphir As for why you want to install something first to test it, well, you can think of it as a way to also test the installer itself. Without this step, it's completely possible to have a passing test suite and yet have a broken installer (and you end up to accidentally publish a broken package).
Just providing some confirmation for others in the same situation as me and going slowly insane: for some projects, neither of these hacks (__init__.py or conftest.py) actually work, the only thing that makes pytest happy is what's shown in the question. You can adjust to relative imports to make pytest run, but then when running the program outside of pytest it doesn't work. Why can't pytest simply use the same PYTHONPATH as python? What on earth is the point of making it different, except causing situations like this?!
|
46

The easy way of doing it is, in terminal/cmd change directory to where the parent directory is, (e.g. in this case cd C:/.../my_project).

Then run: python -m pytest --cov=mypkg tests

No need to mess with the PYTHONPATH environment variable. By running with python -m pytest, it automatically adds the current directory to sys.path.

Improve this answer

3 Comments

+1 This is a legit and documented feature, not just an accident. See docs.pytest.org/en/latest/…
Worth following that link, which explains that python -m pytest departs from the behavior of plain pytest in this one regard.
Great answer, this is IMHO the best and simplest solution by FAR, since it only requires adding a few characters to one's Makefile.
13

The answer is actually much easier, as seen here.

All you need to do is add an __init__.py to your test directory and each of its sub directories, like so;

tests/__init__.py
tests/functional/__init__.py
tests/unit/__init__.py
Improve this answer

4 Comments

This actually adds tests to the package. That may not always be desired.
–1 Because doing this is explicitly discouraged in the "good practices" section of the pytest docs.
@BrianBruggeman, I thought that packages=find_packages(exclude=['contrib', 'docs', 'tests']) in setup.py takes care of that? @wim, that doc now offers two scenarios - having tests inside or outside the app package, so this is now a valid option, I assume?
@AlenSiljak In practice, <repo>/tests is still encouraged and having a tests folder within the structure of the code is discouraged. There are still inconsistent behaviors with pytest's some of plugins that I've run into (I primarily use coverage, isort, flake8). That said, I've begun to put unit tests in tests folders within the code base and integration/system level tests within the top <repo>/tests folder and that has worked out okay for me.
7

Run pytest referencing a single/multiple packages

For 1 package

PYTHONPATH=$(pwd)/mypkg/ python3 -m pytest 
# or
PYTHONPATH=$(pwd)/mypkg/ python3 -m pytest  path/to/tests

For 2 packages (pkg1 pkg2)

# Use ; as a separator in windows
PYTHONPATH=/path/to/pkg1/:/path/to/pkg2/ python3 -m pytest tests
Improve this answer

Comments

Your Answer

By clicking “Post Your Answer”, you agree to our terms of service and acknowledge you have read our privacy policy.

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.