sorting in file and out C++

Question

I have the C++ code. It reading file and look for anagrams in this file ("diction").

while (1)
{
    infile.getline(buff, sizeof(buff));
    if(infile.eof()) break;
    sbuff = buff;
    sort(sbuff.begin(), sbuff.end());
    an.insert(pair<string, string>(sbuff, buff));
}

im = an.begin();
ane = an.end();

vector<multimap<string, string>::iterator> chg;

chg.push_back(im);

while (++im != ane)
{
    chg.push_back(im);
    if((*im).first != (*chg[0]).first)
    {
        if(chg.size() > 2)
        {
            for(unsigned int i=0; i < chg.size() - 1; i++);
        cout << endl;
        }

        chg.clear();
        chg.push_back(im);
    }   

}

if(chg.size() > 1)
    for(unsigned int i=0; i < chg.size(); i++)
        cout << (*chg[i]).second << endl;
    infile.close();
}

After compiling it displays a brunch of empty rows and all. On MacOS on Fedora the same result

What's amiss?

Code comments are "amiss"

noelicus
– noelicus

2014-01-21 10:01:23 +00:00
Commented Jan 21, 2014 at 10:01 — noelicus
– noelicus, Commented Jan 21, 2014 at 10:01

noelicus · Accepted Answer · 2014-01-21 10:03:31Z

2

This for loop doesn't do anything in your code:

 {
    for(unsigned int i=0; i < chg.size() - 1; i++);
    cout << endl;
 }

you don't want the ; at the end of it, probably. If you take it away it'll just give you lots of empty lines though as you don't cout any text to the screen.

answered Jan 21, 2014 at 10:03

noelicus

15.1k4 gold badges96 silver badges116 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ReDSerpenT Over a year ago

thank you very much!!! Thank you very much! I delete ; at the end. And added this line after that: cout << (*chg[i]).second << endl; It's working!

Satish Sharma · Accepted Answer · 2014-01-21 11:36:22Z

1

i thing you miss the {

try this

if(chg.size() > 1)
{
    for(unsigned int i=0; i < chg.size(); i++)
    { 
        cout << (*chg[i]).second << endl;
     }
    infile.close();
}

instead of

if(chg.size() > 1)
    for(unsigned int i=0; i < chg.size(); i++)
        cout << (*chg[i]).second << endl;
    infile.close();
}

answered Jan 21, 2014 at 11:36

Satish Sharma

9,6356 gold badges31 silver badges52 bronze badges

1 Comment

ReDSerpenT Over a year ago

Thank's! In this case the braces no necessary. But it's working though as i don't {}. Although they improve code readability.

Collectives™ on Stack Overflow

sorting in file and out C++

2 Answers 2

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related