Unable to access variable outside of for loop

Question

I am getting some exchange rate data and would like to access the variable outside of the for loop. My current code only results in:

1: 0.82910

but my expected result is:

1: 0.82910

2: 0.82910

I am wondering why this variable is not accessible outside of the loop and how can I make it accessible?

My code (Sorry if the code is bad, Im new to PHP)

$vExchaRates = file_get_contents("http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml");

$xml = simplexml_load_string($vExchaRates);

for ($i = 1; $i <= 32; $i++) {
    if ($xml->Cube[0]->Cube[0]->Cube[$i]->attributes()->currency == "GBP") {
        $vGBPERate = $xml->Cube[0]->Cube[0]->Cube[$i]->attributes()->rate;
        echo "1: " . $vGBPERate . "\r\n";
    }
}

echo "2: " . $vGBPERate;

Thank you for any help you can provide.

no errors? it doesn't look like your code is even reaching the other side of the loop if you don't even see "2: " — Jaak Kütt
– Jaak Kütt, Commented Jan 26, 2014 at 8:10

Rikesh · Accepted Answer · 2014-01-26 08:11:05Z

4

You need to check if object $xml->Cube[0]->Cube[0]->Cube[$i] isset or not.

$vExchaRates = file_get_contents("http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml");
$xml = simplexml_load_string($vExchaRates);

for ($i = 1; $i <= 32; $i++) {
    if (isset($xml->Cube[0]->Cube[0]->Cube[$i]) && $xml->Cube[0]->Cube[0]->Cube[$i]->attributes()->currency == "GBP") {
        $vGBPERate = $xml->Cube[0]->Cube[0]->Cube[$i]->attributes()->rate;
        echo "1: " . $vGBPERate . "\r\n";
   }
}    
echo "2: " . $vGBPERate;

Demo.

Note: Turn on your errors using ini_set("display_errors",1) to get such errors or notices.

answered Jan 26, 2014 at 8:11

Rikesh

26.5k14 gold badges82 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

sergio Over a year ago

+1. Probably the errors is turned off, and he just see first echo.

hexce Over a year ago

This has worked, I will accept this answer :) Thank You for your help. This is hosted php so I am unable to edit the php.ini.

SyntaxLAMP · Accepted Answer · 2014-01-26 08:24:00Z

0

It looks like the 32 was too large and number and is throwing it off. It might be better to use foreach instead. It works perfectly:

$vExchaRates = file_get_contents("http://www.ecb.europa.eu/stats/eurofxref/eurofxref-daily.xml");

$xml = simplexml_load_string($vExchaRates);

foreach($xml->Cube[0]->Cube[0]->Cube as $a)
{

    if ($a->attributes()->currency == "GBP") {
        $vGBPERate = $a->attributes()->rate;
        echo "1: " . $vGBPERate . "\r\n";
}
}

echo "2: " . $vGBPERate;

answered Jan 26, 2014 at 8:24

SyntaxLAMP

9708 silver badges11 bronze badges

Collectives™ on Stack Overflow

Unable to access variable outside of for loop

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related