switch/case statement matlab code

Question

function myFunc = executeCmdByKind(var1,kind)

switch kind
case 'open'
cmdToExecute = [''var1 '','' locationIs '',''clear''];

case 'close'
cmdToExecute = [''var1 '','' locationIs '',''delete''];

case 'move'
cmdToExecute = [''var1 '','' locationIs '',''move''];



   end
a = system(cmdToExecute);
end

My question is : is there a better way "optimal" to write this code as I call the same cmdToExecute only the latest arg changes

Thanks,

What is up with the double ''? Is this supposed to be a cell array of strings? That is very strange Matlab syntax to me. Also you never assign to myFunc so your function will have no output... — Dan
– Dan, Commented Jan 29, 2014 at 9:58

Dan · Accepted Answer · 2014-01-29 10:00:17Z

2

Your syntax makes no sense to me, but I'll stick with it. You could streamline your code like this I guess:

function myFunc = executeCmdByKind(var1,kind)

switch kind
case 'open'
    last = ''clear'';

case 'close'
    last = ''delete'';

case 'move'
    last = ''move'';

end

cmdToExecute = [''var1 '','' locationIs '', last];

answered Jan 29, 2014 at 10:00

Dan

45.8k20 gold badges98 silver badges170 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

tim · Accepted Answer · 2014-01-29 10:02:01Z

1

There are, as always, several ways of doing it. I'd do it like the following:

function myFunc = executeCmdByKind(var1,kind)
  a = {'open', 'close', 'move'};
  b = {'clear', 'delete', 'move'};
  logi = ismember(a, kind);
  cmdToExecute = [var1, locationIs, b{logi}];

That's not the nicest code, but it's short, if you want that ;-) First I look via kind which index it has in the vector a and after retreiving the index, I can then select the corresponding element from b :-)

Edit: Short and it's easily expandable in the future with more elements :-)

answered Jan 29, 2014 at 10:02

tim

10.1k23 gold badges88 silver badges146 bronze badges

7 Comments

Dennis Jaheruddin Over a year ago

The find should be obsolete.

tim Over a year ago

Oh, yeah, sure :-) Logical indexing will also do :-)

Edric Over a year ago

I would add assert(sum(logi) == 1)

Dennis Jaheruddin Over a year ago

@Edric That depends on what you want to happen if kind is not in the list. Good to consider that, but perhaps it wil already work fine or perhaps you don't need to worry about it.

Dennis Jaheruddin Over a year ago

It is a bit of guesswork, but the asker may be interested in this: [var1 ' ' locationIs ' ' b{logi}]

|

Collectives™ on Stack Overflow

switch/case statement matlab code

2 Answers 2

Comments

7 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

7 Comments

Your Answer

Sign up or log in

Post as a guest

Related