Very simple Java syntax errors

Question

So I'm attempting to create a very simple program to practice some basic Java formatting skills. However, something about the "fight()" is driving my compiler crazy. Does anyone see why? Thanks in advance for any answers I receive, code below:

class Hero{
    String name;
    int Intelligence;
    boolean parents;

    public static fight(Hero1, Hero2){
    if(Hero1.Intelligence>Hero2.Intelligence){
        return(Hero1.name+" is the winner");
    else
        return(Hero2.name+" is the winner");
        }
    }
}



class HeroMain{
    public static void main(String[] args){
    Hero Superman = new Hero();
    Superman.name = "Superman";
    Superman.Intelligence = 7;
    Superman.parents = false;

    Hero Batman = new Hero();
    Batman.name = "Batman";
    Batman.Intelligence = 8;
    Batman.parents = false;

    public fight(Superman, Batman);
    }
}

Aside from what the answers already say, you should really check your braces ({}), they seem to be quite out of balance, which may also confuse your compiler. — fvu
– fvu, Commented Feb 3, 2014 at 0:12

La-comadreja · Accepted Answer · 2014-02-03 00:07:23Z

5

you need to write

public static String fight(Hero hero1, Hero hero2) {

You also need to call fight() as follows:

Hero.fight(Superman, Batman);

Also, as a rule of thumb in Java, you should begin all your variables with a lowercase letter. That's just coding convention.

answered Feb 3, 2014 at 0:07

La-comadreja

5,74512 gold badges38 silver badges64 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

TrigonDark Over a year ago

Oh right, I have to specify the type of data returned by the method.I feel kind of silly for forgetting to call the method using dot notation. Thanks for the help!

tommy knocker · Accepted Answer · 2014-02-03 00:09:30Z

3

as La-comadreja stated the issue is the fact your trying to return a string, yet you do not define that on your method header.

example

public static void fight() {} does not return, it just does something public static String fight(){} returns a String

answered Feb 3, 2014 at 0:09

tommy knocker

3711 gold badge7 silver badges21 bronze badges

Comments

pcnThird · Accepted Answer · 2014-02-03 00:17:45Z

1

Here are a few corrections:

class Hero{
    String name;
    int Intelligence;
    boolean parents;

    public static String fight(Hero Hero1, Hero Hero2){ <-- specify type of parameter and return type
        if(Hero1.Intelligence>Hero2.Intelligence) <-- you had a curly-brace problem
            return(Hero1.name+" is the winner");
        else
            return(Hero2.name+" is the winner");
    }
}



class HeroMain{
    public static void main(String[] args){
        Hero Superman = new Hero();
        Superman.name = "Superman";
        Superman.Intelligence = 7;
        Superman.parents = false;

        Hero Batman = new Hero();
        Batman.name = "Batman";
        Batman.Intelligence = 8;
        Batman.parents = false;

        String myStr = Hero.fight(Superman, Batman); <-- call a hero's fight method
        System.out.println(myStr); // "Batman is the winner"
    }

}

answered Feb 3, 2014 at 0:17

pcnThird

2,3722 gold badges20 silver badges33 bronze badges

2 Comments

TrigonDark Over a year ago

Curly brackets for if statements, I should really remember that. Thanks!

pcnThird Over a year ago

It is possible to use if/else statements without curly braces like in the code above, but using braces are preferred if you think you're going to modify something in there later on: stackoverflow.com/questions/2125066/…

Collectives™ on Stack Overflow

Very simple Java syntax errors

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related