How can I possibly know if SQLcommand is properly disposed?

Question

My problem is that my code always returns false because my sqlcommand is not equivalent to null

How can I possibly fix this issue?

Here is my code:

private SqlCommand Command()
    {
        cmd = new SqlCommand(QueryStr, Connection);
        cmd.StatementCompleted += new StatementCompletedEventHandler(cmd_StatementCompleted);
        return cmd;
    }

    private void cmd_StatementCompleted(object sender, StatementCompletedEventArgs e)
    {
        ((SqlCommand)sender).Dispose();
    }

    public object GetScalarResult()
    {
        Command();

        cmd.CommandType = CommandType;

        con.Open();

        return cmd.ExecuteScalar();
    }

    public bool IsDisposedChecker()
    {
        if (cmd == null)
        {
            return true;
        }
        else
        {
            return false;
        }
    }

My IsDisposedChecker function always returns false so that means sqlcommand is not properly disposed?

Dispose() does not reset the pointer to null. So the disposedChecker function does not work this way.. See below.. — Jeroen van Langen
– Jeroen van Langen, Commented Feb 10, 2014 at 8:40
Also, Disposing on StatementComplete looks a bit silly. After the command is complete, don't you want to handle the results of the command? — Jeroen van Langen
– Jeroen van Langen, Commented Feb 10, 2014 at 8:52

Jeroen van Langen · Accepted Answer · 2014-02-10 08:49:40Z

1

Dispose() does not reset the pointer to null. So the ISDisposedChecker function does not work this way..

Dispose isn't a destructor..

I wouldn't implement a dispose-checker, I would put the Dispose responsibility to the caller method if you want to return the SqlCommand as result.

private SqlCommand Command()
{
    cmd = new SqlCommand(QueryStr, Connection);
    return cmd;
}

private void Test()
{
    // a using block is very safe, it will dispose the command 
    // even when exceptions are thrown.
    using(SqlCommand command = Command())
    {
        // do your thing....
    }
}

edited Feb 10, 2014 at 8:49

answered Feb 10, 2014 at 8:44

Jeroen van Langen

22.1k3 gold badges46 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Mukesh Rawat Over a year ago

I think in your code, StatementCompleted is not required.. as user is only disposing object here

Collectives™ on Stack Overflow

How can I possibly know if SQLcommand is properly disposed?

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related