Angular directive how to add an attribute to the element?

Question

I'm wondering what's the way to do work this snippet:

//html
<div ng-app="app">
    <div ng-controller="AppCtrl">
        <a my-dir ng-repeat="user in users">{{user.name}}</a>
    </div>
</div>

//js
var app = angular.module('app', []);
app.controller("AppCtrl", function ($scope) {
    $scope.users = [{name:'John',id:1},{name:'anonymous'}];
    $scope.fxn = function() {
        alert('It works');
    };

})  
app.directive("myDir", function ($compile) {
    return {
        link:function(scope,el){
            el.attr('ng-click','fxn()');
            //$compile(el)(scope); with this the script go mad 
        }
     };
});

I know it's about the compile phase but I don't get the point so a short explanation would be very appreciate.

Possible duplicate of Decorating the ng-click directive in AngularJs — Paul Sweatte
– Paul Sweatte, Commented Jun 22, 2016 at 2:56

Community · Accepted Answer · 2017-05-23 12:34:09Z

89

A directive which adds another directive to the same element:

Much cleaner solution - not to use `ngClick` at all:

A plunker: http://plnkr.co/edit/jY10enUVm31BwvLkDIAO?p=preview

app.directive("myDir", function($parse) {
  return {
    compile: function(tElm,tAttrs){
      var exp = $parse('fxn()');
      return function (scope,elm){
        elm.bind('click',function(){
          exp(scope);
        });  
      };
    }
  };
});

edited May 23, 2017 at 12:34

CommunityBot

11 silver badge

answered Feb 10, 2014 at 22:01

Ilan Frumer

32.4k8 gold badges73 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Jim Cooper Over a year ago

Any idea why this doesn't work when using ng-repeat and calling a function on the directive's controller? I've modified your plunker to show what I mean. Note that the method being called on click is now on the directives controller. Also note that the "This works" link which is not nested in an ng-repeat works while the others do not: plnkr.co/edit/Y4ADmznnDCZvuxJrcZQ0?p=preview

Dinesh Over a year ago

Removing "my-dir" messes up my CSS specification. Is there a workaround to that? Thanks

Ruben.Canton Over a year ago

you could have my-dir-unloaded attr and replace it to my-dir (or to my-dir-loaded) so CSS will work while directive wont get into an infinite loop (just guessing, didn't try)

André Werlang Over a year ago

@Dinesh var fn = $compile(el, null, 1001); and keep my-dir attribute intact.

André Werlang Over a year ago

It's not correct to simply call $compile() on the same element currently being compiled, it would recompile other, unrelated directives that happen to have greater priorities.

|

Yurii Manziuk · Accepted Answer · 2017-02-15 15:00:22Z

2

You can try this:

<div ng-app="app">
    <div ng-controller="AppCtrl">
        <a my-dir ng-repeat="user in users" ng-click="fxn()">{{user.name}}</a>
    </div>
</div>

<script>
var app = angular.module('app', []);

function AppCtrl($scope) {
        $scope.users = [{ name: 'John', id: 1 }, { name: 'anonymous' }];
        $scope.fxn = function () {
            alert('It works');
        };
    }

app.directive("myDir", function ($compile) {
    return {
        scope: {ngClick: '='}
    };
});
</script>

edited Feb 15, 2017 at 15:00

Yurii Manziuk

1035 bronze badges

answered Feb 10, 2014 at 21:29

Kaz-LA

2261 silver badge5 bronze badges

1 Comment

codesnooker Over a year ago

Attribute is suppose to be added on the fly. Not from the template

Collectives™ on Stack Overflow

Angular directive how to add an attribute to the element?

2 Answers 2

A directive which adds another directive to the same element:

Much cleaner solution - not to use `ngClick` at all:

8 Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

A directive which adds another directive to the same element:

Much cleaner solution - not to use ngClick at all:

8 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related

Much cleaner solution - not to use `ngClick` at all: