In Clojure creating a function that creates 'n' JButtons each with different 'actionPerformed' method in other namespace

Question

I have adapted this method from p.216 Joy of Clojure.

 (defn makeButton [txt func panel]
    (let [btn (JButton. txt) ] ;bfun (symbol func) ]
    (doto  btn
        (.addActionListener 
            (proxy [ActionListener] [] (actionPerformed [_] 
                (func))) ;(bfun)))
        ))
        (.add panel btn)
    ))

Plus this test code:

(defn fba [] (prn "fba"))
(defn fbb [] (prn "fbb"))
(def funs [fba fbb])
(def btnames ["B1" "B2"])

Buttons & actionPerformed are created thusly in a gui setup function:

(doseq [i (range (count btnames)) ] 
              (makeButton (get btnames i) (nth funs i) aJpanel))

This works as I want; clicking "B1" prints string "fba", etc. My difficulty arises when I want to attach to 'actionPerformed' something such as: ns1.ns2/myFunction instead of these simple cases (i.e. use a list/vector of several namespaced qualified functions). The exception reported is

wrong number of args (0) passed to Symbol

From the 'makeButton' function above my attempt to solve this is commented out. What is an idiomatic clojure solution to this?

All you should need to do is replace one of the functions in funs with ns1.ns2/myFunction. If you try that (without modifying makeButton from the working version) what happens? — Shepmaster
– Shepmaster, Commented Feb 12, 2014 at 15:47
As an aside, I'd recommend using a map for your labels / functions: (def foo {"B1" fba, "B2" fbb}) and then make your buttons as (doseq [[label f] foo] (make-button label f panel)) — Shepmaster
– Shepmaster, Commented Feb 13, 2014 at 12:45
Thank you for useful advice on use of map. Sometimes one returns to old Java loop habits. — Brian
– Brian, Commented Feb 14, 2014 at 11:38
No worries, I'm still learning Clojure myself, so I try to find code that doesn't look "Clojure-like". :-) — Shepmaster
– Shepmaster, Commented Feb 14, 2014 at 11:44

Shepmaster · Accepted Answer · 2014-02-12 15:56:39Z

1

This code works for me in the REPL. I'm using clojure.pprint/pprint as an example of a function that is in a different namespace:

(import '[javax.swing JFrame JPanel JButton]
        '[java.awt.event ActionListener])

(def panel (JPanel.))

(def frame (doto (JFrame. "Hello Frame")
             (.setContentPane panel)
             (.setSize 200 200)
             (.setVisible true)))

(defn make-button [label f panel]
  (let [button (JButton. label)]
    (doto button
      (.addActionListener
       (proxy [ActionListener] []
         (actionPerformed [evt]
           (f evt)))))
    (.add panel button)))

(make-button "One" clojure.pprint/pprint panel)

(.revalidate frame)

answered Feb 12, 2014 at 15:56

Shepmaster

440k116 gold badges1.3k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Brian Over a year ago

Very strange, but you are correct, your version works. Thank you for helping. Now I have to determine where I messed up.

Collectives™ on Stack Overflow

In Clojure creating a function that creates 'n' JButtons each with different 'actionPerformed' method in other namespace

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related