foreach loop not working with regex

Question

My file images.html contains multiple lines with the following code:

<linestart><urlstart>http://...image.jpg<urlend><idstart>1<idend><lineend>

I want to parse the file but I can’t figure out my error.

My PHP code:

$pattern = "/<linestart>(.*?)<lineend>/s";
$html = file_get_contents('images.html');

$check = preg_match_all($pattern,$html,$match);

foreach($match[1] as $line)
{ 
$pattern2 = "/<urlstart>(.*?)<urlend>/s";
$check2 = preg_match_all($pattern2,$line,$match_url);

$pattern3 = "/<idstart>(.*?)<idend>/s";
$check3 = preg_match_all($pattern3,$line,$match_id);


echo $match_url." id= ".$match_id."<br>";
}

My result is:

Array id= Array
Array id= Array
Array id= Array
Array id= Array
Array id= Array
Array id= Array

Any ideas why?

What are you expecting? $match_url and $match_id are arrays of all the matches. You need to loop over them, like you do with $match. — Barmar
– Barmar, Commented Feb 15, 2014 at 0:09
Can you have more than one <urlstart> or <idstart> in each <linestart> block? If not, you could use preg_match instead of preg_match_all. — Barmar
– Barmar, Commented Feb 15, 2014 at 0:10
each line only has 1 <urlstart>. I tried preg_match instead of preg_match_all.. same result. the result should be URL and the the ID (1 result per line) — user3011784
– user3011784, Commented Feb 15, 2014 at 0:13
You still need to subscript the match to get the capture group. — Barmar
– Barmar, Commented Feb 15, 2014 at 0:13
Barnmar... I don't understand what that means... "subscript to capture the group" ? — user3011784
– user3011784, Commented Feb 15, 2014 at 0:16

Barmar · Accepted Answer · 2014-02-15 00:16:33Z

1

You can match everything in one pattern:

$pattern = "/<linestart>.*?<urlstart>(.*?)<urlend>.*?<idstart>(.*?)<idend>.*?<lineend>/s";
$html = file_get_contents('images.html');

$check = preg_match_all($pattern, $html, $matches, PREG_SET_ORDER);

foreach ($matches as $match) {
    echo $match[1] . " id=" . $match[2];
}

answered Feb 15, 2014 at 0:16

Barmar

789k57 gold badges555 silver badges669 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

foreach loop not working with regex

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related