Thrift Java server OutOfMemoryError with Javascript client

Question

I started learning thrift yesterday.

After a lot of effort, I successfully executed the Java tutorial. Java server and client are running perfectly.

But now, I want a javascript client to communicate with Java Thrift server.

For that, I moved all js files in js/ folder.

And paste index.html code as below:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
<head>
  <meta http-equiv="Content-Type" content="text/html; charset=utf-8" />
  <title>Thrift Javascript Bindings - Tutorial Example</title>

  <script src="js/thrift.js"  type="text/javascript"></script>
  <script src="js/tutorial_types.js"    type="text/javascript"></script>
  <script src="js/shared_types.js"      type="text/javascript"></script>
  <script src="js/SharedService.js"     type="text/javascript"></script>
  <script src="js/Calculator.js"        type="text/javascript"></script>

  <script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script>


  <script type="text/javascript" charset="utf-8">
  //<![CDATA[
  $(document).ready(function(){
    // remove pseudo child required for valid xhtml strict
    $("#op").children().remove();
    // add operations to it's dropdown menu
    $.each(Operation, function(key, value) {
      $('#op').append($("<option></option>").attr("value",value).text(key)); 
    });

     $('table.calculator').attr('width', 500);
  });

  function calc() {
    var transport = new Thrift.Transport("http://localhost:9090");
    var protocol  = new Thrift.Protocol(transport);
    var client    = new CalculatorClient(protocol);

    var work = new Work()
    work.num1 = $("#num1").val();
    work.num2 = $("#num2").val();
    work.op = $("#op").val();

    try {
      result = client.calculate(1, work);
      $('#result').val(result);
      $('#result').css('color', 'black');
    } catch(ouch){
      $('#result').val(ouch.why);
      $('#result').css('color', 'red');
    }
  }

  function auto_calc() {
    if ($('#autoupdate:checked').val() !== undefined) {
      calc();
    }
  }
  //]]>
  </script>

</head>
<body>
  <h2>Thrift Javascript Bindings</h2>
  <form action="">
  <table class="calculator">
    <tr>
      <td>num1</td>
      <td><input type="text" id="num1" value="20" onkeyup="javascript:auto_calc();"/></td>
    </tr>
    <tr>
      <td>Operation</td>
      <td><select id="op" size="1" onchange="javascript:auto_calc();"><option></option></select></td>
    </tr>
    <tr>
      <td>num2</td>
      <td><input type="text" id="num2" value="5" onkeyup="javascript:auto_calc();"/></td></tr>
    <tr>
      <td>result</td>
      <td><input type="text" id="result" value=""/></td></tr>
    <tr>
      <td><input type="checkbox" id="autoupdate" checked="checked"/>autoupdate</td>
      <td><input type="button" id="calculate" value="calculate" onclick="javascript:calc();"/></td>
    </tr>
  </table>
  </form>

  <p>This Java Script example uses <a href="https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=tutorial/tutorial.thrift;hb=HEAD">tutorial.thrift</a> and a Thrift server using JSON protocol and HTTP transport.
  </p>
    <p>
        <a href="http://validator.w3.org/check/referer"><img
            src="http://www.w3.org/Icons/valid-xhtml10"
            alt="Valid XHTML 1.0!" height="31" width="88" /></a>
    </p>
</body>
</html>

I replaced line

var transport = new Thrift.Transport("/thrift/service/tutorial/");

with

var transport = new Thrift.Transport("http://localhost:9090");

As, my server is on port 9090. And /thrift/service/tutorial was not making any sense to me neither it was working.

Then, when I open my page.

Java thrift server crashes with following error:

Exception in thread "main" java.lang.OutOfMemoryError: Java heap space
    at org.apache.thrift.protocol.TBinaryProtocol.readStringBody(TBinaryProtocol.java:339)
    at org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:202)
    at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:27)
    at org.apache.thrift.server.TSimpleServer.serve(TSimpleServer.java:83)
    at thrift.server.CalculatorServer.main(CalculatorServer.java:23)

Here is the CalculatorServer java class.

package thrift.server;

import org.apache.thrift.server.TServer;
import org.apache.thrift.server.TServer.Args;
import org.apache.thrift.server.TSimpleServer;
import org.apache.thrift.transport.TServerSocket;
import org.apache.thrift.transport.TServerTransport;
import org.apache.thrift.transport.TTransportException;

import tutorial.Calculator;

public class CalculatorServer {

    public static void main(String[] args) {
        CalculatorHandler handler = new CalculatorHandler();
        Calculator.Processor<CalculatorHandler> processor = new Calculator.Processor<>(handler);        

        try {
            TServerTransport serverTransport = new TServerSocket(9090);
            TServer server = new TSimpleServer(new Args(serverTransport).processor(processor));

            System.out.println("Starting the simple server...");
            server.serve();
        } catch (TTransportException e) {
            e.printStackTrace();
        }
    }

}

Rest of the code is used from Thrift Tutorials. In fact, Java Thrift server is working perfectly with Java Thrift client. I don't think there is any problem at Java Server side.

Can anyone tell what is going wrong?

Is there any alternative for Javascript client?

I am using thrift to communicate between my Java SE application and a website on local computer. So that, I can develop my GUI using HTML+CSS+JS, rather using Java Swing.

you should run the server with more memory -Xmx1024m for example and try again — user180100
– user180100, Commented Feb 17, 2014 at 6:19

MrOnyancha · Accepted Answer · 2015-11-25 12:04:28Z

I have been looking for an easy way to use thrift inside polymer javascript. Finally here is the solution after It took me three days analyzing other solutions. They where working but they all needed to read the view.html local location file from my http://localhost:8088/view.html request. I found this so expensive since i am using google app engine and compute engine at the same time. i cant locate the local directory on app engine so here is what is did.

Write your java server pretty much like this.

write your polymer element like this

<dom-module id="thrift-client">
<template>
</template>
<script>
    Polymer({
        is:'thrift-client',
        ready:function(){
            var transport = new Thrift.TXHRTransport("http://localhost:8088/service");

            var protocol  = new Thrift.TJSONProtocol(transport);

            var client = new NtvApiClient(protocol);

            var result = client.ping(); // ping the java server. custom

            console.log(result);
        }

        });
</script>

Note that the http://localhost can be changed to http://Your_server_ip_address.
please make sure the java server has a check point exactly named as service
bravo, we have all it takes to access the java server now from a javascript web client without providing any file path.

Note that with this u can easily use in plain js. like this

                var transport = new Thrift.TXHRTransport("http://localhost:8088/service");
                var protocol  = new Thrift.TJSONProtocol(transport);
                var client = new NtvApiClient(protocol);
                var result = client.ping();

Cheers.

yinqiwen · Accepted Answer · 2014-02-17 06:58:49Z

1

Default 'TTransport' is not a http protocol based server. If you want to use http as the communication protocol which seems the only way for js at the client side, you should use a http based 'TTransport'. Take a look at 'org.apache.thrift.server.TServlet', it's a simple way to build a http based thrift server in a servlet.

You should also use 'TJSONProtocol' instead of 'TBinaryProtocol' at server side because thrift js can NOT handle binary data well. This is the code snippet I used before.

public class CalculatorServlet extends TServlet 
{
   public CalculatorServlet() 
   {
      //'Calculator' is the generated class from thrift, 
      //'CalculatorHandler' is the implement class for thrift rpc
      super(new Calculator.Processor(
            new CalculatorHandler()),
            new TJSONProtocol.Factory());
  }
}

edited Feb 17, 2014 at 6:58

answered Feb 17, 2014 at 6:28

yinqiwen

6596 silver badges6 bronze badges

8 Comments

Akshat Over a year ago

Ok, You mean to say, I will have to create a Servlet in order to communicate with JS client?

Akshat Over a year ago

Your code snippet is nice, but please elaborate it more and reference it with my example. So, I can understand it easily.

yinqiwen Over a year ago

You can create a http server instead of 'TServerSocket'. But it's much more complicated. There is only 'TServlet' in thrift java library could help you to do that.

Akshat Over a year ago

But, after creating the servlet instance, how do I attach it with the server? So, it can process incoming requests.

yinqiwen Over a year ago

You should embed a jetty(servlet container) for your servlets in your case. There is a tutorial wiki.eclipse.org/Jetty/Tutorial/Embedding_Jetty

|

JensG · Accepted Answer · 2014-02-17 16:06:06Z

0

IIRC, JavaScript supports only the JSON protocol. This is (of course) incompatible with binary.

Therefore the solution is: use the JSON protocol instead of the binary protocol in your server.

A good rule of thumb with Thrift is, to always use the same transport/protocol stack on both ends. In this particilar case this means:

HTTP Server
JSON protocol
no extras like framed protocol (buffered would work, btw)

(There are some exceptions, because some server types intrinsically require framed, but that's a whole other story and has nothing to do with your problem)

answered Feb 17, 2014 at 16:06

JensG

13.5k4 gold badges51 silver badges61 bronze badges

2 Comments

Akshat Over a year ago

I've successfully set the Java Server protocol to TJSONProtocol, but how to solve the transport part?

JensG Over a year ago

There are two classes, TExtensibleServlet extends HttpServlet, which seem to be the way to go. There's some more documentation over here people.apache.org/~thejas/thrift-0.9/javadoc/org/apache/thrift/… Haven't used it myself.

Collectives™ on Stack Overflow

Thrift Java server OutOfMemoryError with Javascript client

3 Answers 3

Comments

8 Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

8 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related