Javascript Function Not Stopping Button.Click ASP.Net Code

Question

I have been frustrated today with what seems like an easy piece of code. I cannot seem to get the OnClientClick to not run the ASP.net code if I try to use a custom Javascript function. However if I use just the standard "javascript:return confirm('whatever')" that will stop the submit if I click cancel. Can you help me to understand why my custom function is not working to do the same thing?

Here is the code for the button:

<asp:Button ID="ButtonSubmitChanges" runat="server" Text="Submit Changes" Class="justround" autofocus="autofocus" 
    OnClientClick="javascript:myCustomConfirm()"/>

Here is the VB.Net Function that handles the button click:

    Protected Sub ButtonSubmitChanges_Click(ByVal sender As Object, ByVal e As System.EventArgs) Handles ButtonSubmitChanges.Click

    Dim ChangeErrorMessage As String = SubmitChanges()

    If ChangeErrorMessage.Length <= 0 Then

        Response.Redirect("ViewChangeRequest.aspx?CRID=" & ChangeRequest_ID.ToString)
    Else
        labelSystemMessage.Text = ChangeErrorMessage
    End If
End Sub

And here is the customer Javascript function:

function myCustomConfirm() {

return confirm("Are you sure?");
}

Again, why will it stop the onclick with the normal return confirm() and click Cancel, but not stop the code when I use my function and click cancel?

It's been a while, but I believe you need to use AutoWireup="false" in your .aspx. — Scottie
– Scottie, Commented Feb 20, 2014 at 18:29
You're not returning the value returned by "myCustomConfirm()". You're just calling it and throwing away the result. — Pointy
– Pointy, Commented Feb 20, 2014 at 18:30
Oh my goodness, it was so simple that I want to bash my head against the keyboard. Thank you @Pointy I knew it seemed too difficult.... — user3334102
– user3334102, Commented Feb 20, 2014 at 18:39

Aric TenEyck · Accepted Answer · 2018-11-21 19:06:10Z

2

You need to put a return in the OnClientClick handler.

<asp:Button ID="ButtonSubmitChanges" runat="server" 
Text="Submit Changes" Class="justround" autofocus="autofocus"    
OnClientClick="javascript:return myCustomConfirm()"/>

edited Nov 21, 2018 at 19:06

answered Feb 20, 2014 at 18:32

Aric TenEyck

8,0521 gold badge37 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user3334102 Over a year ago

Geez, I knew it was something simple, but now I just feel ridiculous. Thank you so much @AricTenEyck!

Collectives™ on Stack Overflow

Javascript Function Not Stopping Button.Click ASP.Net Code

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related