C++: I want to copy/store data from struct into individual arrays

Question

I wrote a basic get function that takes the elements of a struct, and copies/stores them into separate variables. I want to do the same thing, except to store an array of structs into array variables (the key thing is that I want to use the get function that I already wrote). I can easily do what I want to do without embedding my first function, but I am required to use my first function in the second, and am having some problems.

One of my errors is that there isn't a matching function call in the embedded get function that I put inside my second function (I thought that I matched up the variables correctly with my first get function (i.e. n, c, a, and x)).

Thanks for looking.

#include <iostream> 
#include <cstdlib> 

using namespace std; 

struct ABC
{ 
    int n; 
    char c; 
    double a[3]; 
}; 


void get( int & n, char & c, double a[3], const ABC & x )
{ 
    n = x.n; 
    c = x.c; 

    for (int i = 0; i < 3; i++){ 
    a[i] = x.a[i]; 

    } 
} 

void get( int n[], char c[], double a[][3], const ABC x[], int elements )
{
    for (int i = 0; i < elements; i++){ 

    get(n, c, a, x); 

    } 

} 

int main()
{ 

    ABC x = {number, m, {1, 2, 3}}; 

    ABC xx[4] = { 

    {123, 'A', {1.1, 1.2, 1.3}}, 
    {234, 'B', {2.1, 2.2, 2.3}}, 
    {345, 'C', {3.1, 3.2, 3.3}}, 
    {456, 'D', {4.1, 4.2, 4.3}} 

    }; 

    int n; 
    char c; 
    int a[] = {}; 

    int n1 [4] = {}; 
    char c1 [4] = {}; 
    double a3 [4] [3] = {}; 

    int elements = 3; 

    get(n1, c1, a3, xx, elements); 

    return 0; 
}

Some indentation would be nice.

jia103
– jia103

2014-02-23 21:32:32 +00:00
Commented Feb 23, 2014 at 21:32 — jia103
– jia103, Commented Feb 23, 2014 at 21:32
The title reminds me of XY-problems immediately. So: Why?

sehe
– sehe

2014-02-23 21:48:41 +00:00
Commented Feb 23, 2014 at 21:48 — sehe
– sehe, Commented Feb 23, 2014 at 21:48

sehe · Accepted Answer · 2014-02-23 21:51:35Z

1

You probably wanted to say

get(n[i], c[i], a[i], x[i]);

This is not answering your XY-problem though

"fixed" code (to compile) Live On Coliru

answered Feb 23, 2014 at 21:51

sehe

400k49 gold badges475 silver badges673 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user2411290 Over a year ago

Thank you! Don't know why I forgot to just add the index to each of the parameters. Lots of HW, so it probably just slipped the mind.

ShadowMitia · Accepted Answer · 2014-02-24 00:09:08Z

1

It seems to me that in your get functions with the arrays you're always storing the values into the same place in each array. You should probably be doing something like:

get(n[i], c[i], a[i], x[i] );

edited Feb 24, 2014 at 0:09

answered Feb 23, 2014 at 21:56

ShadowMitia

2,5531 gold badge24 silver badges26 bronze badges

Collectives™ on Stack Overflow

C++: I want to copy/store data from struct into individual arrays

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related