JS alert function with multiple line string

Question

I have a php function which generates a javascript alert popup.

This function accepts a parameter message. My problem is that if message is a multiple line string, javascript won't alert the text because of the lack of '+' every line. How can I solve that?

function alert($msg) {
    echo '<script type="text/javascript">alert("'.$msg.'")</script>';
}

/* DOESN'T WORK */
  $msg = 'testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttest.
      testtesttesttesttesttesttesttest.
      testtesttesttesttesttesttesttesttesttest.';
  alert($msg);

/* WORKS */
  $msg = 'testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttest. testtesttesttesttesttest. testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttesttestttesttesttesttesttesttest.';
  alert($msg);

Why -1? Isn't this a serious question?!? @Pilot can you explain me why /? — Perocat
– Perocat, Commented Feb 24, 2014 at 13:37

Jim Jeffries · Accepted Answer · 2014-02-24 13:39:24Z

2

The problem is multiline strings in javascript need to be split with a \ at the end of each line.

function alert($msg) {
    echo '<script type="text/javascript">alert("'.$msg.'")</script>';
}

$msg = 'testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttest.\
      testtesttesttesttesttesttesttest.\
      testtesttesttesttesttesttesttesttesttest.';
alert($msg);

answered Feb 24, 2014 at 13:39

Jim Jeffries

10.1k16 gold badges66 silver badges105 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Girish · Accepted Answer · 2014-02-24 13:46:55Z

0

Please user json_encode function in pass function parameter
json_code function is change link break into \n

<?php 
 function alert($msg) {
    echo '<script type="text/javascript">alert('.$msg.')</script>';
}

/* DOESN'T WORK */
  $msg = 'testtesttesttesttesttesttesttesttesttesttesttesttesttesttesttest.
      testtesttesttesttesttesttesttest.
      testtesttesttesttesttesttesttesttesttest.';
  alert(json_encode($msg));
 ?>

This chrome enter image description here

edited Feb 24, 2014 at 13:46

answered Feb 24, 2014 at 13:39

Girish

12.2k3 gold badges37 silver badges54 bronze badges

5 Comments

Jim Jeffries Over a year ago

This won't work. The problem is the multiline string, not the function parameter.

Girish Over a year ago

@jamesj, json_encode function will add \r\n of line break so it will work

Jim Jeffries Over a year ago

But the line above there isn't valid javascript. Try pasting it into the chrome dev console. It gives me SyntaxError: Unexpected token ILLEGAL

Girish Over a year ago

@jamesj please see attachment image, i used same code

Jim Jeffries Over a year ago

Executing it as a php script first though. Nowhere does the question mention PHP (although I now notice that is what OP was using).

Collectives™ on Stack Overflow

JS alert function with multiple line string

2 Answers 2

Comments

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related