Accessing private variable in PHP's code

Question

Why doesn't the following output the data I'm expecting?

class student
{
    private $name;
    private $id;

    public function _construct($name,$id)
    {
        $this->name = $name;
        $this->id = $id; 
    }

    public function getName()
    {
        return $this->name;
    }

    public function getID ()
    {
        return $this->id;
    }
}
$mhs = new student("budi","152012102");

echo "name = ".$mhs->getName();

I don't know what's happening, help?

oh that just a TYPO ,AFTER I FIX IT, IT STILL DOESN'T OUTPUT THE 'name' — user2713275
– user2713275, Commented Mar 3, 2014 at 10:46
helo, u can test the the code here writecodeonline.com/php , or in your IDE , it just doesnt output the 'name' — user2713275
– user2713275, Commented Mar 3, 2014 at 10:48
@febri23: DON'T SHOUT, WE CAN READ LOWER-CASE LETTERS, TOO. And while all upper-case comments aren't considered good form, a class name should start with an UpperCase, and the rest of the name is CamelCased... just so you know: php-fig.org — Elias Van Ootegem
– Elias Van Ootegem, Commented Mar 3, 2014 at 10:51

duellsy · Accepted Answer · 2014-03-03 10:51:49Z

5

Two problems:

1) Calling the constructor

When you call the constructor, you need to prefix it with TWO underscores.

So in full, you constructor should be:

public function __construct($name, $id)
{
    $this->name = $name;
    $this->id = $id;
}

2) Typo

There also seems to be a simple typo in your constructor:

You're assigning $nama instead of $name

$this->name = $nama;

This should be

$this->name = $name;

[EDIT] This typo seems to be fixed in the main question now

edited Mar 3, 2014 at 10:51

answered Mar 3, 2014 at 10:44

duellsy

8,6432 gold badges38 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

user2713275 Over a year ago

oh that just a TYPO ,AFTER I FIX IT, IT STILL DOESN'T OUTPUT THE 'name'

Realitätsverlust Over a year ago

Why is this wrong answer upvoted? You cant access private variables like that.

user2713275 Over a year ago

so how should i access the private variable ??

cypherabe Over a year ago

@YUNOWORK it's in the constructor, the answer is correct...the code should output the desired string

duellsy Over a year ago

noticed another issue with the constructor, modified my answer (see section 1)

|

Collectives™ on Stack Overflow

Accessing private variable in PHP's code

1 Answer 1

1) Calling the constructor

2) Typo

8 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1) Calling the constructor

2) Typo

8 Comments

Your Answer

Sign up or log in

Post as a guest

Related