Saving Changes to Database Using LINQ and ASP.NET

Question

I have this code. The code will find the correct log but won't save any changes back to the database. How would I get it to save?

var query = from log in db.Logs
            where log.LogID == id
            select log;

foreach (Log log in query)
{
    log.DateTimeResolved = System.DateTime.Now;
    db.Entry(query).State = EntityState.Modified;
}

try
{
    db.SaveChanges();
}
catch (Exception e)
{ }

return RedirectToAction("Index");

Don't use an empty catch block - any error you get is being ignored. — D Stanley
– D Stanley, Commented Mar 3, 2014 at 16:33
The assumption is that you are throwing an error, catching it, and discarding it. What, if anything, is the value of e when you debug this? — crthompson
– crthompson, Commented Mar 3, 2014 at 16:35
You shouldn't have to set the state to modified. The state tracking should do that automatically. — Dave Swersky
– Dave Swersky, Commented Mar 3, 2014 at 16:36

D Stanley · Accepted Answer · 2014-03-03 16:37:18Z

1

Well it's hard to say since you're ignoring any exception that is thrown, but this looks suspect:

foreach (Log log in query)
{
    log.DateTimeResolved = System.DateTime.Now;
    db.Entry(query).State = EntityState.Modified;
}            ^---  should be "log" instead of "query"?

My guess is that since Entry() takes an object it compiles but at runtime you're getting an error and ignoring it. As stated in the comments, you should not need to explicitly set the state to Modified since you're modifying the entity directly. I think you just need:

foreach (Log log in query)
{
    log.DateTimeResolved = System.DateTime.Now;
}

answered Mar 3, 2014 at 16:37

D Stanley

153k12 gold badges190 silver badges257 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

ASPCoder1450 Over a year ago

db.SaveChanges() throws Validation failed for one or more entities. See 'EntityValidationErrors' property for more details.

ASPCoder1450 · Accepted Answer · 2014-03-03 19:49:01Z

0

There was a Required field in my Log entity class causing the problem. Though why would it need to set this again if i'm just updating and not adding?

answered Mar 3, 2014 at 19:49

ASPCoder1450

1,6614 gold badges24 silver badges49 bronze badges

Collectives™ on Stack Overflow

Saving Changes to Database Using LINQ and ASP.NET

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related