Loop not properly adding to list

Question

I want to list all objects in my ScoresList to a list box.

private void UpdateStudentScores_Load(object sender, EventArgs e)
{
    students.Fill();
    txtName.Text = students[index].WholeName;
    lstScores.Items.Clear();
    int s = 0;
    for (int i = 0; i < students[index].ScoresList.Count; i++)
        s = students[index].ScoresList[i];
        lstScores.Items.Add(s);
}

I want to be adding "s" to my list four times because the students[index].ScoresList.Count = 4. Instead I only get the last element in my list displayed. Where did I go wrong?

Type Ctrl-E Ctrl-D in Visual Studio's code editor and you will see... — Olivier Jacot-Descombes
– Olivier Jacot-Descombes, Commented Mar 8, 2014 at 22:02

Selman Genç · Accepted Answer · 2014-03-08 21:46:58Z

2

You need this:

lstScores.Items.Add(students[index].ScoresList[i]);

Or the curly braces:

for (int i = 0; i < students[index].ScoresList.Count; i++)
{
    s = students[index].ScoresList[i];
    lstScores.Items.Add(s);     
}

If you have more than one line in the body of your loop use curly braces. Your loop run four times but only add your last item because s become equal to last item after the loop.When you don't use curly-braces only the first line that comes after the loop considered as loop body.So lstScores.Items.Add(s); executing after the loop.

answered Mar 8, 2014 at 21:46

Selman Genç

102k15 gold badges126 silver badges193 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Loop not properly adding to list

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related