undefined method `+' for nil:NilClass

Question

I want to complete a cart part in a site. The first time i add items into the cart it is ok, but the second time with the same items i would get a error:

undefined method `+' for nil:NilClass

Extracted source (around line #19):

current_item = line_items.find_by_product_id(product_id)  
if current_item  
  current_item.quantity += 1  
else  
  current_item = line_items.build(product_id: product_id)  
end

What is wrong?

Thanks.

Roland Mai · Accepted Answer · 2014-03-13 07:40:39Z

1

The quantity field is probably null in the database. Change the infringing line to something like:

current_item.quantity = current_item.quantity.to_i + 1

answered Mar 13, 2014 at 7:40

Roland Mai

31.2k8 gold badges58 silver badges61 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alok Anand · Accepted Answer · 2014-03-13 07:42:15Z

1

nil.to_i returns 0

So use current_item.quantity = current_item.quantity.to_i + 1

answered Mar 13, 2014 at 7:42

Alok Anand

3,3761 gold badge22 silver badges17 bronze badges

1 Comment

Alok Anand Over a year ago

current_item.quantity.to_i += 1 will return error if quantity value is nil.

Sergey K · Accepted Answer · 2014-03-13 07:48:41Z

1

Seems like current_item.quantity is nil.

Try to set default value with

...
if current_item
  current_item.quantity ||= 1 # sets to 1 if nil
  current_item.quantity += 1  
else
...

If you store quantity in database, then add to your migration like null: false, default: 1

Hope it helps.

edited Mar 13, 2014 at 7:48

answered Mar 13, 2014 at 7:42

Sergey K

5,1073 gold badges34 silver badges52 bronze badges

Collectives™ on Stack Overflow

undefined method `+' for nil:NilClass

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related