Javascript:Toggle Function is not working

Question

I am trying to make a simple toggle but it is not working.And i want it done in javascript not in jquery. Here is my javascript.

<script>
function showhide() {

    if (document.getElementById(ptag).style.display = "block") {
        document.getElementById(ptag).style.display = "none";
    } else {
        document.getElementById(ptag).style.display = "block";
    }
}
</script>

Here is my HTML.

<input type="button" value="Show hide" onclick="showhide()">
<p id="ptag">Some text here.</p>

I need solution :(

did you try getElementById('ptag')

Nizam
– Nizam

2014-03-13 14:29:15 +00:00
Commented Mar 13, 2014 at 14:29 — Nizam
– Nizam, Commented Mar 13, 2014 at 14:29

Ian Clark · Accepted Answer · 2014-03-13 14:12:05Z

3

Change your if condition to:

if(document.getElementById("ptag").style.display == "block"){
                           ^^^^ string                ^^^ double equals

And replace all other references of ptag to "ptag"

See working JSFiddle

answered Mar 13, 2014 at 14:12

Ian Clark

9,3874 gold badges36 silver badges49 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ian Clark Over a year ago

Sorry? Your question wasn't really upvote worthy to be honest. I'm not sure you tried to find the solution yourself in anyway before asking here.

Collectives™ on Stack Overflow

Javascript:Toggle Function is not working

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related