mysql update query doesn't work

Question

I have this php file for store the logout time. Using insert query I store the login time first. Then I store the logout time using this logout script. The error I'm getting is the one I mentioned in my code which is failed to insert logout time. the $lgotime and $lrec are echoing correctly. Below is my code:

<?php

session_start();

$lgotime = date("Y-m-d H:i:s");

$lrec = $_SESSION['lreclast'];

echo $lgotime;

echo "</br>";

echo $lrec;

mysql_query("UPDATE tbl_login_record SET logoff_time='$lgotime' WHERE id = '$lrec'") or die("failed to insert logout time");

session_destroy();
header("Location:../login.php");
?>

the $lrec variable is coming from mysql_insert_id() from the script that has the insert query. Help will be really appreciated.

what.. you are trying to insert or update?

zzlalani
– zzlalani

2014-03-17 10:03:26 +00:00
Commented Mar 17, 2014 at 10:03 — zzlalani
– zzlalani, Commented Mar 17, 2014 at 10:03
I'm trying to update.

Janaka Dombawela
– Janaka Dombawela

2014-03-17 10:04:32 +00:00
Commented Mar 17, 2014 at 10:04 — Janaka Dombawela
– Janaka Dombawela, Commented Mar 17, 2014 at 10:04
hey where is the connection string here...

Codesen
– Codesen

2014-03-17 10:20:15 +00:00
Commented Mar 17, 2014 at 10:20 — Codesen
– Codesen, Commented Mar 17, 2014 at 10:20

RayanFar · Accepted Answer · 2015-07-30 14:25:46Z

3

if your mysql query dosent work you can change your code like this:

mysql_query("UPDATE tbl_login_record SET logoff_time='".$lgotime."' WHERE id = '".$lrec."'") or die("failed to insert logout time");

it always works for me!

edited Jul 30, 2015 at 14:25

answered Mar 17, 2014 at 10:31

RayanFar

58711 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

David Hirst · Accepted Answer · 2014-03-17 10:06:25Z

1

The problem is that your query is not sending the data, its sending strings

mysql_query("UPDATE tbl_login_record SET logoff_time='$lgotime' WHERE id = '$lrec'") or die("failed to insert logout time");

Should be,

mysql_query("UPDATE tbl_login_record SET logoff_time='{$lgotime}' WHERE id = {$lrec}") or die("failed to insert logout time");

To be honest I would not suggest this either and would use parametrized queries instead.

answered Mar 17, 2014 at 10:06

David Hirst

2,0322 gold badges25 silver badges32 bronze badges

3 Comments

Charaf JRA Over a year ago

you are in php , not java or javascript ; concat using dot

David Hirst Over a year ago

Even so, the ID is going to be an integer presumably so id='$lrec' will still be incorrect.

Ravinder Reddy Over a year ago

@DavidHirst: MySQL ignores quotes around numerics when being set to numeric fields.

M I · Accepted Answer · 2014-03-17 10:06:28Z

1

Please give it a try. You are not using session_start() on top of this page and change query as

<?php 
 session_start();
 $lgotime = date("Y-m-d H:i:s");

$lrec = $_SESSION['lreclast'];

echo $lgotime;

echo "</br>";

echo $lrec;

mysql_query("UPDATE tbl_login_record SET logoff_time='".$lgotime."' WHERE id = '".$lrec."'") or die("failed to insert logout time");

session_destroy();
header("Location:../login.php");

answered Mar 17, 2014 at 10:06

M I

3,6822 gold badges27 silver badges38 bronze badges

Comments

sri hs · Accepted Answer · 2014-03-17 10:07:29Z

1

Change the query into the below format and try,

mysql_query("UPDATE tbl_login_record SET logoff_time='".$lgotime."' WHERE id = '".$lrec."'") or die("failed to insert logout time");

answered Mar 17, 2014 at 10:07

sri hs

1161 silver badge9 bronze badges

Comments

Charaf JRA · Accepted Answer · 2014-03-17 10:14:33Z

1

Just remove single quotes from the id in your query because it is integer not String

mysql_query("UPDATE tbl_login_record SET logoff_time='$lgotime' WHERE id = $lrec") or die("failed to insert logout time");

answered Mar 17, 2014 at 10:14

Charaf JRA

8,3551 gold badge36 silver badges45 bronze badges

Collectives™ on Stack Overflow

mysql update query doesn't work

5 Answers 5

Comments

3 Comments

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

3 Comments

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related