String.Format: why is this code not working?

Question

I'm getting FormatException with this piece of code

string yyyy = OPENING_DATE.Substring(0, 4);
string mm = OPENING_DATE.Substring(4, 2);
string dd = OPENING_DATE.Substring(6, 2);
ncbaccount.Date_Opened = string.Format("{1}/{2}/{3}",dd,mm,yyyy);

PROBLEM: OPENING_DATE is like '20140317'

SOLUTION: I want a string like '17/03/2014'

Thanks

Format placeholders begin at {0}, not {1}.

Frédéric Hamidi
– Frédéric Hamidi

2014-03-17 10:24:56 +00:00
Commented Mar 17, 2014 at 10:24 — Frédéric Hamidi
– Frédéric Hamidi, Commented Mar 17, 2014 at 10:24
Change "{1}/{2}/{3}" to "{0}/{1}/{2}".

Alessandro D'Andria
– Alessandro D'Andria

2014-03-17 10:25:24 +00:00
Commented Mar 17, 2014 at 10:25 — Alessandro D'Andria
– Alessandro D'Andria, Commented Mar 17, 2014 at 10:25

Sergey Berezovskiy · Accepted Answer · 2014-03-17 10:26:32Z

11

Instead of splitting your date string, then formatting it and parsing, you can use DateTime.ParseExact and provide format of date string:

DateTime date = 
     DateTime.ParseExact(OPENING_DATE, "yyyyMMdd", CultureInfo.InvariantCulture);

answered Mar 17, 2014 at 10:26

Sergey Berezovskiy

237k44 gold badges441 silver badges468 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Adam Houldsworth Over a year ago

@oliverdejohnson This will then let you hold the date in a proper DateTime type and go on to convert back to a string with better formatting options available.

Usman Waheed Over a year ago

also use .ToString() for above, as you want the date in string format

oliverdejohnson Over a year ago

ok many thanks...I like the idea.in converting back to the required string format i added this below your code: string.Format("{0:dd/mm/yyyy}",date);

Henrik · Accepted Answer · 2014-03-17 10:25:37Z

6

Replace {1}/{2}/{3} with {0}/{1}/{2} as it begins at 0.

Ex:

string yyyy = OPENING_DATE.Substring(0, 4);
        string mm = OPENING_DATE.Substring(4, 2);
        string dd = OPENING_DATE.Substring(6, 2);
        ncbaccount.Date_Opened = string.Format("{0}/{1}/{2}", dd, mm, yyyy);

answered Mar 17, 2014 at 10:25

Henrik

1,8174 gold badges24 silver badges47 bronze badges

1 Comment

oliverdejohnson Over a year ago

chosen as answer cos it answered the original question. Implemented Sergey's solution though cos its kinda neater

Nikhil Agrawal · Accepted Answer · 2014-03-17 10:27:25Z

0

Only change this line

string.Format("{0}/{1}/{2}", dd, mm, yyyy);

More over you should be using DateTime Functions to parse date and times.

answered Mar 17, 2014 at 10:27

Nikhil Agrawal

48.8k25 gold badges134 silver badges212 bronze badges

Collectives™ on Stack Overflow

String.Format: why is this code not working?

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related