select_tag and javascript in rails issue

Question

Im trying to generate html using rails select_tag and save it into a variable to be dynamically used. For some reason, below is causes this error:

Uncaught syntax error: Unexpected token ILLEGAL

Below is the problem code:

function addItemRowHTML(offsetidentifiervalue)
{
    $node = ' \
         <%= select_tag "currency",  
            options_for_select(Country.all.each_with_index.map {
            |country, index| 
                [country["currency_code"],
                 country["currency_code"]]},
                @invoice["data"]["currency"] ),
                :style => "width:120px"
        %> \
        ';

}

text_field_tag works though

$node =' <%= text_field_tag("amount", "10") %> ';

so how would i handle select_tag ? thanks

here are some of my failed example attempts: gist.github.com/axilaris/9615678 — Axil
– Axil, Commented Mar 18, 2014 at 8:54
check the generated javascript - it will likely have unescaped single quotes in it, therefore be invalid syntax. — sevenseacat
– sevenseacat, Commented Mar 18, 2014 at 8:54
you are right but its not unescaped single quotes, its probably unescaped multiline from the options generated gist.github.com/axilaris/9616215 — Axil
– Axil, Commented Mar 18, 2014 at 9:00
then it probably needs reformatting to insert \ on unescaped multiline — Axil
– Axil, Commented Mar 18, 2014 at 9:00

Community · Accepted Answer · 2017-05-23 11:49:47Z

2

<% html_select_tag = select_tag( "currency",  
      options_for_select(Country.all.map(&:currency_code),
      @invoice["data"]["currency"] ),
      :style => "width:120px" ).gsub("\n", "\\n").gsub("'","\\'") %>

var $node = '<%= html_select_tag %>';

Someone already answered similar question here: https://stackoverflow.com/a/13631186/2134720

edited May 23, 2017 at 11:49

CommunityBot

11 silver badge

answered Mar 18, 2014 at 9:10

Ahmed Abbas

96211 silver badges26 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Axil Over a year ago

i dont think that works. previous works... im not sure if you can assign html_select_tag, atleast that didnt work

Ahmed Abbas Over a year ago

Supposed to work. Tested it. What kind of error did it raise for you?

Axil Over a year ago

_form.html.erb:320: syntax error, unexpected tSTRING_DEND, expecting ')' options_for_select(Country.all.map(&:currency_code)}, ^

Ahmed Abbas Over a year ago

oops the curly brace close is not supposed to be there. Updated the answer. Let me know if it works now.

Axil Over a year ago

actually it does work with html_select_tag variable... but with the code below. do you want me to reedit the code from below, and i'll mark it as answered ? I'll just mark it right anyway, all depends probably how you want it, main thing is gsub replacement code. thats what is important.

|

Axil · Accepted Answer · 2014-03-18 10:02:00Z

this works

    $node = '<% select_tag("currency",  
            options_for_select(Country.all.each_with_index.map {
            |country, index| 
                [country["currency_code"],
                 country["currency_code"]]},
                @invoice["data"]["currency"] ),
                :style => "width:120px").gsub("\n", "\\n").gsub("'","\\'")
    %> ';

and this would be a better solution, there are less newlines to escape using raw

    $node = '<% raw select_tag("currency",  
            options_for_select(Country.all.each_with_index.map {
            |country, index| 
                [country["currency_code"],
                 country["currency_code"]]},
                @invoice["data"]["currency"] ),
                :style => "width:120px").gsub("\n", "\\n").gsub("'","\\'")
    %> ';

Collectives™ on Stack Overflow

select_tag and javascript in rails issue

2 Answers 2

8 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

8 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related