Create listview in fragment android

Question

As the title I want to create a listview with custom row in Fragment. My code below.

Fragment class

public class PhotosFragment extends Fragment{

public PhotosFragment(){}

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container,
        Bundle savedInstanceState) {

    View rootView = inflater.inflate(R.layout.fragment_photos, container, false);

    ArrayList<ListviewContactItem> listContact = GetlistContact();
    ListView lv = (ListView)getActivity().findViewById(R.id.lv_contact);
    lv.setAdapter(new ListviewContactAdapter(getActivity(), listContact));

    return rootView;
}

private ArrayList<ListviewContactItem> GetlistContact(){
    ArrayList<ListviewContactItem> contactlist = new ArrayList<ListviewContactItem>();

    ListviewContactItem contact = new ListviewContactItem();

    contact.SetName("Topher");
    contact.SetPhone("01213113568");
    contactlist.add(contact);

    contact = new ListviewContactItem();
    contact.SetName("Jean");
    contact.SetPhone("01213869102");
    contactlist.add(contact);

    contact = new ListviewContactItem();
    contact.SetName("Andrew");
    contact.SetPhone("01213123985");
    contactlist.add(contact);

    return contactlist; 
    }   
}

Adapter class

public class ListviewContactAdapter extends BaseAdapter{
private static ArrayList<ListviewContactItem> listContact;

private LayoutInflater mInflater;

public ListviewContactAdapter(Context photosFragment, ArrayList<ListviewContactItem> results){
    listContact = results;
    mInflater = LayoutInflater.from(photosFragment);
}

@Override
public int getCount() {
    // TODO Auto-generated method stub
    return listContact.size();
}

@Override
public Object getItem(int arg0) {
    // TODO Auto-generated method stub
    return listContact.get(arg0);
}

@Override
public long getItemId(int arg0) {
    // TODO Auto-generated method stub
    return arg0;
}


public View getView(int position, View convertView, ViewGroup parent) {
    // TODO Auto-generated method stub
    ViewHolder holder;
    if(convertView == null){
        convertView = mInflater.inflate(R.layout.contact_item, null);
        holder = new ViewHolder();
        holder.txtname = (TextView) convertView.findViewById(R.id.lv_contact_item_name);          
        holder.txtphone = (TextView) convertView.findViewById(R.id.lv_contact_item_phone);

        convertView.setTag(holder);
    } else {
        holder = (ViewHolder) convertView.getTag();
    }

    holder.txtname.setText(listContact.get(position).GetName());
    holder.txtphone.setText(listContact.get(position).GetPhone());

    return convertView;
}

static class ViewHolder{
    TextView txtname, txtphone;
}
}

But when I run the app that display no thing. Could anyone tell me what wrong here and how can I fix it?

I'm also trying the same thing. Can you give me the full source code? — gangadhars
– gangadhars, Commented Sep 27, 2014 at 18:08
All thing I posted in my quension. And you can also find out many tutorial about listview on google. — gamo
– gamo, Commented Sep 29, 2014 at 6:56
for me too same does not turn out here my the code stackoverflow.com/questions/26254727/… — user3796282
– user3796282, Commented Oct 9, 2014 at 5:26
Hi @gamo can you show me code for layout "contact_item" and Java "ListviewContactItem". I am trying to do something similar. — vikas devde
– vikas devde, Commented Sep 20, 2017 at 9:13

Raghunandan · Accepted Answer · 2014-03-20 04:50:26Z

40

I guess your app crashes because of NullPointerException.

Change this

ListView lv = (ListView)getActivity().findViewById(R.id.lv_contact);

to

ListView lv = (ListView)rootView.findViewById(R.id.lv_contact);

assuming listview belongs to the fragment layout.

The rest of the code looks alright

Edit:

Well since you said it is not working i tried it myself

enter image description here

edited Mar 20, 2014 at 4:50

answered Mar 19, 2014 at 16:57

Raghunandan

134k26 gold badges232 silver badges261 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Raghunandan Over a year ago

@user3422401 alright i will try your code and get back in 5 minutes. But the codes look alright

Raghunandan Over a year ago

@user3422401 it works fine i only made changes as i suggested in my post.

Raghunandan Over a year ago

@user3422401 do check the snaps works well. SO we need more info. The code posted is fine. Where do you add fragment to the activity. post the xml layouts

gamo Over a year ago

I tried but it doesn't work for me. My Fragment class inside a sliding menu call by MainActivity but I think it's not important.

Raghunandan Over a year ago

@user3422401 AFAIK there is nothing wrong in the code you posted. There is something wrong else where

|

Julisch · Accepted Answer · 2014-03-19 17:35:15Z

4

Please use ListFragment. Otherwise, it won't work.

EDIT 1: Then you'll only need setListAdapter() and getListView().

edited Mar 19, 2014 at 17:35

answered Mar 19, 2014 at 17:28

Julisch

4183 silver badges18 bronze badges

3 Comments

gamo Over a year ago

Let me try. I will leave you the result.

ADL Over a year ago

can you give us an example of how ListFragment works?

Julisch Over a year ago

Take a look at this: tutorialspoint.com/android/android_list_fragment.htm

Aman · Accepted Answer · 2014-08-23 07:09:42Z

2

you need to give:

public void onActivityCreated(Bundle savedInstanceState)    
{
  super.onActivityCreated(savedInstanceState);
}

inside fragment.

edited Aug 23, 2014 at 7:09

Aman

5,77010 gold badges57 silver badges92 bronze badges

answered Aug 23, 2014 at 7:04

user3936680

Comments

IntelliJ Amiya · Accepted Answer · 2015-12-08 12:33:10Z

The inflate() method takes three parameters:

The id of a layout XML file (inside R.layout),
A parent ViewGroup into which the fragment's View is to be inserted,
A third boolean telling whether the fragment's View as inflated from the layout XML file should be inserted into the parent ViewGroup.

In this case we pass false because the View will be attached to the parent ViewGroup elsewhere, by some of the Android code we call (in other words, behind our backs). When you pass false as last parameter to inflate(), the parent ViewGroup is still used for layout calculations of the inflated View, so you cannot pass null as parent ViewGroup .

 View rootView = inflater.inflate(R.layout.fragment_photos, container, false);

So, You need to call rootView in here

ListView lv = (ListView)rootView.findViewById(R.id.lv_contact);

VictorPurMar · Accepted Answer · 2014-09-25 20:02:59Z

0

Instead:

public class PhotosFragment extends Fragment

You can use:

public class PhotosFragment extends ListFragment

It change the methods

    @Override
    public void onActivityCreated(Bundle savedInstanceState) {
        super.onActivityCreated(savedInstanceState);
        ArrayList<ListviewContactItem> listContact = GetlistContact();
        setAdapter(new ListviewContactAdapter(getActivity(), listContact));
    }

onActivityCreated is void and you didn't need to return a view like in onCreateView

You can see an example here

edited Sep 25, 2014 at 20:02

answered Sep 25, 2014 at 18:32

VictorPurMar

3011 silver badge9 bronze badges

Collectives™ on Stack Overflow

Create listview in fragment android

5 Answers 5

8 Comments

3 Comments

Comments

The inflate() method takes three parameters:

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

8 Comments

3 Comments

Comments

The inflate() method takes three parameters:

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related