Trying to get 1 array of strings from a database column with mysqli

Question

I am trying to get all the values from a column with mysqli. I have tried

$emaildbs = $db->query("SELECT email from subscribers");
while($emaildbsrow = $emaildbs->fetch_row()) {
  $emaildbsrows[] = $emaildbsrow;
}
var_dump($emaildbsrows);

but the var_dump looks like this:

array(2) {
  [0]=>
  array(1) {
    [0]=>
    string(6) "asdasd"
  }
  [1]=>
  array(1) {
   [0]=>
   string(1) "s"
  }
}

and the expected output is

array(2) {
  [0]=> string(6) "asdasd"
  [1]=> string(1) "s"
}

I have also tried:

with fetch_assoc and I get smth similar. I searched on stackoverflow, and tried numerous functions instead of fetch_row but same thing. Where am I mistaking.

Rikesh · Accepted Answer · 2014-03-20 09:53:15Z

1

You're assigning complete row to $emaildbsrows array so just change it to,

$emaildbs = $db->query("SELECT email from subscribers");
while($emaildbsrow = $emaildbs->fetch_row()) {
  $emaildbsrows[] = $emaildbsrow[0];
}
var_dump($emaildbsrows);

answered Mar 20, 2014 at 9:53

Rikesh

26.5k14 gold badges82 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Fluffeh · Accepted Answer · 2014-03-20 09:54:39Z

1

Each row is an array itself - but as you are selecting a single column, it is a single index array.

You might want to do the following instead:

$emaildbs = $db->query("SELECT email from subscribers");
while($emaildbsrow = $emaildbs->fetch_row()) {
  $emaildbsrows[] = $emaildbsrow[0];
}
var_dump($emaildbsrows);

This will add the single element from the array as a new element in $emaildbsrows. As you are only selecting a single column from the table, this will work nicely. Had you selected more than one column, this wouldn't work.

answered Mar 20, 2014 at 9:54

Fluffeh

33.6k16 gold badges69 silver badges80 bronze badges

Comments

Your Common Sense · Accepted Answer · 2014-03-20 10:12:10Z

1

You should use abstraction libraries instead of raw mysqli, such as PDO

$sql = "SELECT email from subscribers";
$emails = $pdo->query($sql)->fetchAll(PDO::FETCH_COLUMN, 0));

or safeMysql

$emails = $db->getCol("SELECT email from subscribers");

the purpose of an abstraction library is to get rid of all the dirty job, making your code cleaner and more readable. See - everything can be done in one single line, making your code four times shorter. Assuming 20 queries per page in average it can save you 60 lines of code.

However, to tell you truth, I don't believe myself you would follow this suggestion. According to my observations, PHP users rather inclined to writing as much code as possible, producing screens of code out of every trifle operation.

edited Mar 20, 2014 at 10:12

answered Mar 20, 2014 at 9:58

Your Common Sense

158k42 gold badges226 silver badges374 bronze badges

2 Comments

user3140607 Over a year ago

My database connection is though mysqli, don't think it will work with PDO. BTW, is PDO faster or smth? I noticed that mysqli is most used.

Your Common Sense Over a year ago

PDO is saner. If your connection is mysqli you can use safeMysql as its built upon mysqli

Collectives™ on Stack Overflow

Trying to get 1 array of strings from a database column with mysqli

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related