ASP.NET MVC5 Get all registered AspNetUsers in a list view

Question

My goal is simple. I want to list all registered users in my ASP.NET MVC5 for administrational purposes. Here's my AccountController code:

     [Authorize(Roles = "Admin")]
     public ActionResult AdminUserManagement()
     {
        var context = new IdentityDbContext();

        var allUsers = context.Users.ToList();



        var viewModels = new List<ManagerUserViewModel>();

        foreach (var user in allUsers)
        {
            viewModels.Add(new ManagerUserViewModel { UserID = user.Id, UserName =  user.UserName, Role = user.Roles.First().Role.ToString() });
        }

        return View(viewModels);
    }

But fore some reason the allUsers list, is empty. When I run the application, The View works just fine, but picks up no Users at all.

The View:

@model IEnumerable<GUI.Models.ManagerUserViewModel>

@{
   ViewBag.Title = "User Management";
 }

 <h2>User Management</h2>


 <table class="table">
    <tr>
       <th>
          @Html.DisplayNameFor(model => model.UserName)
       </th>
        <th>
           @Html.DisplayNameFor(model => model.Role)
       </th>
    <th></th>
 </tr>

 @foreach (var item in Model) {
 <tr>
    <td>
        @Html.DisplayFor(modelItem => item.UserName)
    </td>
    <td>
        @Html.DisplayFor(modelItem => item.Role)
    </td>
    <td>
        @Html.ActionLink("Edit", "Edit", new { /* id=item.PrimaryKey */ }) |
        @Html.ActionLink("Details", "Details", new { /* id=item.PrimaryKey */ }) |
        @Html.ActionLink("Delete", "Delete", new { /* id=item.PrimaryKey */ })
    </td>
 </tr>
  }

 </table>

The IdentityDB:

using ClassLibrary.Entities;
using Microsoft.AspNet.Identity;
using Microsoft.AspNet.Identity.EntityFramework;


namespace DAL.DataContexts
{
   public class IdentityDb : IdentityDbContext<ApplicationUser>
{
    public IdentityDb()
        : base("WhitelabelDb")
    {
    }
}
}

What's wrong with my code, and why?

Put a breakpoint over var allUsers ... . Does that get populated? — CallumVass
– CallumVass, Commented Mar 20, 2014 at 14:09
No it doesn't. I alredy put the breakpoint over that line of code. — Assassin87
– Assassin87, Commented Mar 20, 2014 at 14:42

João Simões · Accepted Answer · 2014-03-20 14:06:57Z

2

Well, looking at your code I can't see a bigger problem, but you aren't disposing your database context as you should. Try the following code and see if it helps:

[Authorize(Roles = "Admin")]
public ActionResult AdminUserManagement()
{
    IEnumerable<ManagerUserViewModel>() viewModels;
    using(var context = new IdentityDbContext()){

        viewModels =
            context.Users
            .Include("Roles")
            .Select(u =>
                new ManagerUserViewModel { 
                    UserID = u.Id, 
                    UserName =  u.UserName, 
                    Role = u.Roles.First().Role.ToString() 
                }
            ).ToList();
    }

    return View(viewModels);
}

answered Mar 20, 2014 at 14:06

João Simões

1,3711 gold badge11 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

user3409638 · Accepted Answer · 2014-03-20 14:20:52Z

0

Maybe because of tolist , please try below , i am not sure, it works or not

 viewModels.Tolist();

or

send your allUsers to your view directly using without foreach.

Write your foreach code in your view

edited Mar 20, 2014 at 14:20

answered Mar 20, 2014 at 14:14

user3409638

1673 silver badges13 bronze badges

1 Comment

Vasil Dininski Over a year ago

I think that foreach-ing the IQueryable would result in a N+1 query, i.e. foreach(var user in allUsers)

Vasil Dininski · Accepted Answer · 2014-03-20 14:26:15Z

0

Shouldn't you be using IdentityDb instead of IdentityDbContext:

var context = new IdentityDb();

the rest should be the same.

answered Mar 20, 2014 at 14:26

Vasil Dininski

2,4181 gold badge21 silver badges32 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC5 Get all registered AspNetUsers in a list view

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related