Why my string replace is not working in JavaScript? [duplicate]

Question

I'm trying to replace a placeholder in a string I'm generating.

My string looks like this:

 var s = 'module("SlapOS UI Basic Interaction"); ' +
         'asyncTest( "${base_url}", function() { ' +
         ' expect( __number__ ); ' +
         ' ok(testForElement("div#global-panel"), "element present");' +
         ' start(); })';

And I want to replace __number__.

I can get the index correctly like so:

 s.indexOf("__number__");

but replacing does not work...

 s.replace("__number__", "1");

Question:
What am I doing wrong here? Makes no sense to my why it does not work.

Works for me. Hate to ask this, but maybe you're forgetting to assign the result of the replace to something? — David Sherret
– David Sherret, Commented Mar 28, 2014 at 16:48

Bryan · Accepted Answer · 2017-09-09 18:30:13Z

3

The replace method does not modify the existing string. It returns a new one.

var result = s.replace("__number__", "1");

edited Sep 9, 2017 at 18:30

Bryan

2,85525 gold badges39 silver badges45 bronze badges

answered Mar 28, 2014 at 16:49

Denys Lieu

2702 silver badges9 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

frequent Over a year ago

darn.... I think I always forget :-)

Collectives™ on Stack Overflow

Why my string replace is not working in JavaScript? [duplicate]

1 Answer 1

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Linked

Related