How to use variable variable in find view by id

Question

i will like to use variable cb in findViewById as below, but it is giving me an error, any ideas how to do it

public class Compare1 extends Activity{


@Override
protected void onCreate(Bundle savedInstanceState) {
    // TODO Auto-generated method stub
    super.onCreate(savedInstanceState);
    setContentView(R.layout.commac1);
    // setdesign();
    ImageView btn=(ImageView) findViewById(R.id.comparenow);
    btn.setOnClickListener(new View.OnClickListener() {

        @Override
        public void onClick(View v) {
            // TODO Auto-generated method stub
            for(int check=1;check<17;check++){
                int a=check;
            String cb="checkBox"+a;
               int id=getResources().getIdentifier(cb, "id", getPackageName());
                CheckBox cb=(CheckBox) findViewById(id);
                if(cb.isChecked()){
                    Toast.makeText(Compare1.this, "you selected" +cb, Toast.LENGTH_SHORT).show();
                    }}

        }
    });

why are you not giving the resource id like you did with the imageview? — tyczj
– tyczj, Commented Apr 3, 2014 at 20:30
@tyczj because there are 16 checkboxes, it will be very messy — Rajeev
– Rajeev, Commented Apr 3, 2014 at 20:31
i am checking on my device and the application is stopping after i click on imageview. if i remove the for loop and hardcode the cb variable as cb1,cb2... it is working fine — Rajeev
– Rajeev, Commented Apr 3, 2014 at 20:34

hasan · Accepted Answer · 2014-04-03 20:34:13Z

1

try:

int id= Compare1.this.getResources().getIdentifier(cb, "id", getPackageName());

using getResources() alone makes this method exist in the OnClickListener object.

Also:

(CheckBox) Compare1.this.findViewById(id);

answered Apr 3, 2014 at 20:34

hasan

24.2k10 gold badges67 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Rajeev Over a year ago

@ hasan if i remove the for loop and hardcode the cb variable as cb1,cb2... it is working fine. no issues with this line.issue is with this line CheckBox cb=(CheckBox) findViewById(id);

Collectives™ on Stack Overflow

How to use variable variable in find view by id

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related