Converting string to const* char

Question

I have two string declarations:

killerName
victimName

I need to convert these two string values to const* char.

Example of how I use my method:

if (killer.IsRealPlayer) {
   killerName = killer.GetName(); -- need to convert to const* char
   victimName = victim.GetName(); -- need to convert to const* char

   Notice(killerName + "has slain:" + victimName, killer.GetMapIndex(), false); 
}

Some error I receive:

Error 111 error C2664: 'Notice' : cannot convert parameter 1 from 'std::basic_string<_Elem,_Traits,_Ax>' to 'const char */

This is really unclear. The output and code do not match your question or title. — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Apr 3, 2014 at 22:58
And your new edit is completely off-target. Do you know what happens if you do const char* + "has slain:" + const char* ? — Ben Voigt
– Ben Voigt, Commented Apr 3, 2014 at 23:04

Vlad from Moscow · Accepted Answer · 2014-04-03 23:04:22Z

4

It seems that function Notice have the first parameter of type const char * However the expression passed to it as the first argument

killerName + "has slain:" + victimName

has type std::string

Simply call the function the following way

Notice( ( killerName + "has slain:" + victimName ).c_str(), killer.GetMapIndex(), false);

answered Apr 3, 2014 at 23:04

Vlad from Moscow

313k27 gold badges204 silver badges358 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Suedocode · Accepted Answer · 2014-04-03 23:04:15Z

3

Notice(string(killerName + "has slain:" + victimName).c_str(), killer.GetMapIndex(), false);

std::string::c_str() gives the const char* to the buffer. I think that's what you want.

See: http://www.cplusplus.com/reference/string/string/c_str/

edited Apr 3, 2014 at 23:04

answered Apr 3, 2014 at 22:58

Suedocode

2,5443 gold badges25 silver badges42 bronze badges

Comments

Mr.C64 · Accepted Answer · 2014-04-03 23:30:38Z

As others already wrote, the result of killerName + "has slain:" + victimName is of type std::string. So, if your Notice() function expects a const char* as first parameter, you must convert from std::string to const char*, and since there is no implicit conversion defined for std::string, you must call the std::string::c_str() method:

Notice((killerName + "has slain:" + victimName).c_str(), killer.GetMapIndex(), false);

However, I'd like to ask: why do you have Notice() expecting a const char* as first parameter?
Would it be better to just use const std::string&? In general, in modern C++ code, you may want to use string classes like std::string instead of raw char* pointers.

(Another option would be to have two overloads of Notice(): one expecting a const std::string& as first parameter, and the other one expecting a const char*, if for some reason the const char* version does make sense in your particular context; this double overload pattern is used e.g. in the std::fstream constructor.)

Collectives™ on Stack Overflow

Converting string to const* char

3 Answers 3

Comments

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related