How to find correct position to insert an element in a sorted array?

Question

I have to make a program in Java to create a sorted array in descending order. When i try to insert 10, 3 it is ok, but when i insert 10, 3, 8 the result is 10, 8, 0. For some reason the 0 appears on the end. Also when i try to imput negative numbers like -2 the result becomes -2, 8, 0. Can someone help? Also, is bubble sort the correct method for this kind of insertion? (Sorry for my english it is my first time here). Thank you for your time.

    private int searchPosition(int a)
    {
        int position = 0;

        for (int i = 0; i < array.length(); i++)
        {
            if(array[i] != a)
            {
                if((array[i] > a) && (array[i + 1] < a))
                {
                    position = i + 1;
                }
            }
            else
            {
                position = i;
            }
        }

        return position;
    }

    public boolean insert(int a)
    {
        int position;
        boolean exists;
        int temp;

        if (size == capacity)
        {
            System.out.println("The array is full.");
            return false;
        }
        else
        {
            exists = //here i call a method to make sure the element to insert doesn't exist in the array

            if (exists == false)
            {
                //Bubble Sort in desceding order
                for (int i = 0; i < array.length(); i++)
                {
                    for (int j=0; j < array.length() - i; j++)
                    {
                        if (array[j] < array[j + 1])
                        {
                            temp = array[j + 1];
                            array[j + 1] = array[j];
                            array[j] = temp;
                        }
                    }
                }
                position = searchPosition(a);
                //move elements one position to the right
                for (int i = array.length(); i < position; i--)
                {
                    array[i] = array[i - 1];
                }
                array[position] = a;
                //place a in the free position
                size++;
                return true;
            }
            else
            {
                System.out.println("The element" + a + " already exists in the array.");
                return false;
            }
        }
    }

Attach a debugger, step through the code. This is how you learn. — Kon
– Kon, Commented Apr 6, 2014 at 1:21
i debugged it and the result is this 10 3 Insert 8 The array is: 10 8 0 — flower
– flower, Commented Apr 6, 2014 at 1:33
Binary Search on array for 1+elem. Index for insertion is the position before the result. Then shift the array and insert the elem. — Azar
– Azar, Commented Apr 6, 2014 at 1:48
@flower I fail to see what bubble sort has to do with it. Since you are saying you have to create a sorted array in descending order. — WonderWorld
– WonderWorld, Commented Apr 6, 2014 at 1:59

WonderWorld · Accepted Answer · 2014-04-06 22:24:13Z

3

You can do this with a break statement, where you exit the loop when a value is smaller then a value in the array and use this index.

int value = 8;
for(int i = 0; i < array.length; i++) {
    if(array[i] < value) {
        break;
    }
}

for(int j = array.length; j > i; j--) {
    a[j] = a[j -1];
}
a[j] = value;
size++;

edited Apr 6, 2014 at 22:24

answered Apr 6, 2014 at 1:48

WonderWorld

9661 gold badge8 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to find correct position to insert an element in a sorted array?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related