The C program crashes while executing function

Question

Hello I have a problem when I call to function arrayBigToSmall the program crashes (after I enter the numbers). I want to understand why this happens and how I can fix this problem.?

Code -

    #include <stdio.h>
    #include <stdlib.h>

    int main()
    {
    float array[2][3][2];
    getNums(array);
    return(0);
    }

    void getNums(float array[2][3][2])
    {
    int i,j,p;

    printf("Enter numbers: \n");
    for(i = 0; i < 2 ; i++)
    {
        for(j = 0; j < 3; j++)
        {
            for(p = 0; p < 2; p++)
            {
                scanf("%f",&array[i][j][p]);
            }
        }
    }
    arrayBigToSmall(array);
    }

    void arrayBigToSmall(float array[2][3][2])
    {

    int i,j,p,k;
    float array1[12];
    float temp;

    for( i=0; i<3; i++)
    {
        for( j=0; j  < 2; j++)
        {
            for(p = 0; p < 3; p++)
            {
                array1[k] = array[i][j][p];
                k++;
            }
        }
    }
    }

you failed to initialize k in arrayBigToSmall(). Your compiler would have told you if you compiled with all warnings enabled. — mfro
– mfro, Commented Apr 6, 2014 at 9:06

mesmerizingr · Accepted Answer · 2014-04-06 09:10:48Z

4

for( i=0; i<3; i++)
{
    for( j=0; j  < 2; j++)
    {
        for(p = 0; p < 3; p++)
        {
            array1[k] = array[i][j][p];
            k++;
        }
    }
}
}

k must be initialized to 0. i should be not greater than 2, j not greater that 3, and p not greater than 2

answered Apr 6, 2014 at 9:10

mesmerizingr

1,4472 gold badges18 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

EmptyData · Accepted Answer · 2014-04-06 09:12:44Z

2

Be careful with size of array use following: as the dimension of your array is 2 x 3 x 2 but in your code you are using 3 loops in 3 x 2 x 3 manner which overflows and which result in crash . Also you should intialise k before using it.

void arrayBigToSmall(float array[2][3][2])
{

int i,j,p,k=0;
float array1[12];
float temp;

for( i=0; i<2; i++)
{
    for( j=0; j  < 3; j++)
    {
        for(p = 0; p <2 ; p++)
        {
            array1[k] = array[i][j][p];
            k++;
        }
    }
}
}

edited Apr 6, 2014 at 9:12

answered Apr 6, 2014 at 9:07

EmptyData

2,6064 gold badges29 silver badges44 bronze badges

Collectives™ on Stack Overflow

The C program crashes while executing function

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related