java: ArrayList() method returning a result : if passing argument or without passing it

Question

I want to write the method listCopies() that returns in an ArrayList all copies of a written work in a given language(eg : english); if no language is given (empty string), all copies of the library will be returned (in all languages) . This is the code i have developed but it doesnt work cause in the main(String[] args) {...} it calls 2 times this method , one with the argument passed and in the second without an argument :

public ArrayList<Exemplary> listCopies(String l){
    ArrayList <Exemplary> tmp = new ArrayList<Exemplary>();
    for( int i = 0 ; i < copies.size(); i++){  
                 if(copies.get(i).getWrittenWork().getLanguage().equals(language)){ 
                tmp.add(Ex);
             }
    }
    return (tmp);}

I want to rewrite this code in a way that with or without argument (String lang) > it returns the array tmp .

Side note, you have String lang passed to the method, but referenced an language in the code of the method. — AntonH
– AntonH, Commented Apr 7, 2014 at 21:43
if no language is given (empty string), all copies of the library will be returned (in all languages): you haven't implemented this rule. Just do it. — JB Nizet
– JB Nizet, Commented Apr 7, 2014 at 21:45
Are having problem compiling your code? If yes, then what's the problem? — Bhesh Gurung
– Bhesh Gurung, Commented Apr 7, 2014 at 21:49

dimo414 · Accepted Answer · 2014-04-07 22:17:13Z

1

There's a multitude of problems with your code:

lang is used on the first line, but further on you use language
Exemplary is used on the first line, but on the 2nd you use Exemplairy
the method doesn't have a closing } at the end
you don't have code that deals with an empty language
the loop should be rewritten as an enhanced for loop
the interface List should be used instead of the class ArrayList where possible

edited Apr 7, 2014 at 22:17

dimo414

49.3k19 gold badges167 silver badges275 bronze badges

answered Apr 7, 2014 at 22:13

wggn

776 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

NadNet Over a year ago

public ArrayList<Exemplaire> listerExemplaires(String l){ ArrayList <Exemplaire> tmp = new ArrayList<Exemplaire>(); for( int i = 0 ; i < exemplaires.size(); i++){ if(exemplaires.get(i).getOeuvre().getLangue().equals(langue)){ tmp.add(Ex); } } return (tmp); }

NadNet Over a year ago

please take a look again to my question above , i gave more explanations to my problem

Collectives™ on Stack Overflow

java: ArrayList() method returning a result : if passing argument or without passing it

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related