Escape Javascript in PHP

Question

I am Trying to escape these darn quotes and stuff in JS. I'm trying to use json_encode. My head hurts from looking at quotes, help???

  $list = '';

    // some loop here

   $message = 'centeredPopup(this.href,"myWindow","500","300","yes")';
   $jscode = 'json_encode('.$message.');return false';
   $list .= '<p> 
        <a href="http://www.example.com/something.php?id=' . $id . '" onclick="' 
              .htmlspecialchars($jscode) . '" >' . $name . '</a></p><br>';

Why are you putting the javascript in PHP variables to begin with? — david brainerd
– david brainerd, Commented Apr 9, 2014 at 4:52
I have no idea what you're trying to do. json_encode() is not javascript, so why encapsulate it in a string? — user1864610
– user1864610, Commented Apr 9, 2014 at 4:52
i was using this example. stackoverflow.com/questions/7085648/… i'm generating a list of links that create popup windows or was trying to. this may not be the best way though ^_^ — Clam
– Clam, Commented Apr 9, 2014 at 4:57
I would say rather than putting a long string of javascript inside a onClick attribute, make a named javascript function and have your onClick reference it. — david brainerd
– david brainerd, Commented Apr 9, 2014 at 5:09

PurkkaKoodari · Accepted Answer · 2014-04-09 04:52:18Z

1

If you want to call json_encode there, you need to do this.

$jscode = json_encode($message).';return false';

You don't even need json_encode for this. You can put this there:

$message = 'centeredPopup(this.href,"myWindow","500","300","yes")';
$jscode = $message.';return false';
$list .= '<p> <a href="http://www.example.com/something.php?id=' . $id . '" onclick="' .htmlspecialchars($jscode) . '" >' . $name . '</a></p><br>';

answered Apr 9, 2014 at 4:52

PurkkaKoodari

6,8296 gold badges42 silver badges59 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Justin Mitchell · Accepted Answer · 2014-04-09 04:53:25Z

0

Try:

$message = 'centeredPopup(this.href,"myWindow","500","300","yes")';
$jscode = json_encode($message);

Otherwise everything else should be OK.

answered Apr 9, 2014 at 4:53

Justin Mitchell

3041 silver badge5 bronze badges

Collectives™ on Stack Overflow

Escape Javascript in PHP

2 Answers 2

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related