Regex is not a function

Question

I'm trying to create a simple validation method with jQuery, but without a plugin. So I made this code:

(function ($) {
  $.fn.validate = function () {
    var emailRegex = '^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$';
    var error = false;
    if ($('#vorname').val() == "") {
      $('#vorname').after('<span class="error">Name fehlt</span>');
      error = "true";
    }
    if ($('#nachname').val() == "") {
      $('#nachname').after('<span class="error">Name fehlt</span>');
      error = "true";
    }
    if ($('#email').val() == "") {
      $('#email').after('<span class="error">Email fehlt</span>');
      error = "true";
    } else if (!emailRegex.test($('#email').val())) {
      $('#email').after('<span class="error">Keine gültige Email</span>');
      error = "true";
    }
    if (error == true) {
      return false;
    } else {
      return;
      true;
    }
  }
})(jQuery);

$(document).ready(function () {
  $('#button').click(function () {
    $('#button').validate();
  });
});

But I'm getting always the message that my regex test isn't a function. What's the issue?

You might find the discussion in question Validate email address in JavaScript? interesting as well. — ojdo
– ojdo, Commented Apr 10, 2014 at 9:21

ojdo · Accepted Answer · 2014-04-10 09:18:53Z

3

You write:

var emailRegex = '^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$';

You might want to write:

var emailRegex = new RegExp('^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$');
// or simpler
var emailRegex = /^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/;

answered Apr 10, 2014 at 9:18

ojdo

9,1358 gold badges43 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

user3518669 Over a year ago

now i got the problem that the email isnt valid also when its a real email adress

ojdo Over a year ago

Follow the link in my comment to your question for other/better expressions to validate addresses. Also: only one question per question ;-)

Kei Minagawa · Accepted Answer · 2014-04-10 09:16:21Z

1

Your emailRegex is defined as String. Define it as regexp like this.

emailRegex = /hogehoge/

answered Apr 10, 2014 at 9:16

Kei Minagawa

4,5515 gold badges31 silver badges43 bronze badges

Collectives™ on Stack Overflow

Regex is not a function

2 Answers 2

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related