Return data from Service, not promise

Question

I'm looking to have a bit of a cleaner controller to not muddy it up with promise api stuff.

Here's an example of what I'm talking about:

Some Service

...
.service('SomeService', function SomeService($http) {
  this.getAllItems = function() {
    return $http.get('api/items')
      .success(function(data) {
        return data;
      });

Controller

...
SomeService.getAllItems().then(function(response) {
  $scope.items = response.data;
});
...

I'm trying to avoid the extra function call on the promise and assign items directly like so:

$scope.items = SomeService.getAllItems();

Is this possible? I've tried calling the then within the service, and it still ends up returning a promise object once it's resolved in the controller, but I'm probably doing something wrong. Thanks!

That would make the call non-async - what's wrong with using .then()? — tymeJV
– tymeJV, Commented Apr 15, 2014 at 15:56
Nothing is "wrong" with it, just feels ... dirty, I don't know. — dardo
– dardo, Commented Apr 15, 2014 at 15:57
I'm assuming by this comment, the .then() callback delegates once the response is received, otherwise it'd block? — dardo
– dardo, Commented Apr 15, 2014 at 15:58
If you are using ngRoute you can use the resolve property of the route. — tasseKATT
– tasseKATT, Commented Apr 15, 2014 at 16:13

Chandermani · Accepted Answer · 2014-04-15 16:15:59Z

1

You can use the $resource class to do it. This is from the documentation

It is important to realize that invoking a $resource object method immediately returns an empty reference (object or array depending on isArray). Once the data is returned from the server the existing reference is populated with the actual data. This is a useful trick since usually the resource is assigned to a model which is then rendered by the view. Having an empty object results in no rendering, once the data arrives from the server then the object is populated with the data and the view automatically re-renders itself showing the new data. This means that in most cases one never has to write a callback function for the action methods.

answered Apr 15, 2014 at 16:15

Chandermani

42.7k12 gold badges88 silver badges89 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

dardo Over a year ago

Hrm, this might be exactly what I'm looking for!

Collectives™ on Stack Overflow

Return data from Service, not promise

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related