MySQL query not executing

Question

<?php
include("db.php");
$name=$_REQUEST['name'];
$mail=$_REQUEST['email'];
$yname=$_REQUEST['yname'];
$result=mysql_query("SELECT * FROM information WHERE uname = '$name' ");

if (mysql_num_rows($result) == 0) {

    $query=mysql_query("INSERT into noresult (Serial,searchname,yourname,email)
        VALUES ('',$name','$yname','$mail')");
    if ($query){
        header('Location:nullresult.php');
    }
    else{
        echo "Query failure";
    }

}

?>

This returns 'Query Failure'. It was working sometime back with table name 'seeker'. Then I dropped it and created a new table 'noresult' as the previous one was a bit messed up. Suddenly the query fails.

Note: seeker and noresult have same columns.

By building SQL statements with outside variables, you are leaving yourself open to SQL injection attacks. Also, any input data with single quotes in it, like a name of "O'Malley", will blow up your SQL query. Please learn about using parametrized queries, preferably with the PDO module, to protect your web app. This question has many examples in detail. You can also see bobby-tables.com/php for alternatives and explanation of the danger. — Andy Lester
– Andy Lester, Commented Apr 17, 2014 at 17:39
Thanks. Didn't know about these. As a beginner my primary goal was to see whether I could implement certain things. Will take care of the issues next time. — Abhishek Singh
– Abhishek Singh, Commented Apr 17, 2014 at 18:30
The other big benefit of using prepared statements is that you don't run into the quoting problems that you ran into above. — Andy Lester
– Andy Lester, Commented Apr 17, 2014 at 18:31

larsAnders · Accepted Answer · 2014-04-17 17:21:27Z

2

You're missing a single quote in your query:

$query=mysql_query("INSERT into noresult (Serial,searchname,yourname,email)
    VALUES ('','$name','$yname','$mail')");
      there----^

answered Apr 17, 2014 at 17:21

larsAnders

3,8031 gold badge17 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Patrick Moore Over a year ago

I'd double check the casing of Serial vs. serial, too, if this doesn't solve it for you right away. +1

larsAnders Over a year ago

From the MySQL documentation: "Column and index names are not case sensitive on any platform, nor are column aliases." However, table names are case-sensitive on certain platforms, so you may want to check noresult.

Abhishek Singh Over a year ago

There is no issue of casing. I tried with both serial and Serial.

shashank · Accepted Answer · 2014-04-17 17:34:31Z

0

Try this updated query-

$query=mysql_query("INSERT into noresult (Serial,searchname,yourname,email)
        VALUES ('','".$name."','".$yname."','".$mail."')");

also check all column name from table noresult.

answered Apr 17, 2014 at 17:34

shashank

5663 gold badges12 silver badges32 bronze badges

Collectives™ on Stack Overflow

MySQL query not executing

2 Answers 2

3 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related