Push a Object onto another Javascript object [duplicate]

Question

I have this javascript Object named group.

I am trying to add another object into this called Rule if the group.Rule object is null. My code is like so:

var ruleObj = { 
    Id: null, 
    RuleId: null, 
    MatchLogic: 0, 
    Min: null, 
    Max: null, 
    TagIds: null 
};

group.Rule = group.Rule == null ? group.Rule = ruleObj : group.Rule;

I would think that group.Rule = ruleObj would do it but console logging it shows that group.Rule is {} empty.

How do I add the group.Rule object onto group?

Your ternary operator should only include one assignment: group.Rule = group.Rule == null ? ruleObj : group.Rule; — more succinctly you could use an or operator (||): group.Rule = ruleObj || group.Rule. This won't resolve your problem though :) — Barney
– Barney, Commented Apr 22, 2014 at 18:55
Write out your solution as an answer and mark it as accepted for the benefit of others — you might also consider using a library like Underscore or Lodash for utilities like isEmpty (and extend, which could probably help with higher-level problems). — Barney
– Barney, Commented Apr 22, 2014 at 18:58

Stepan Riha · Accepted Answer · 2014-04-22 18:57:39Z

0

A more efficient assignment would be:

group.Rule || (group.Rule = ruleObj);

instead of

group.Rule = group.Rule == null ? group.Rule = ruleObj : group.Rule;

However, note that {} != null (an empty object is truthy), so if you initialized Rule to an empty object, you'll need to change your assignment test.

answered Apr 22, 2014 at 18:57

Stepan Riha

1,72414 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

vtortola · Accepted Answer · 2014-04-22 18:52:27Z

0

It should work this way as you said:

var group = {};

var ruleObj = { Id: null, RuleId: null, MatchLogic: 0, Min: null, Max: null, TagIds: null};
group.Rule = group.Rule == null ? ruleObj : group.Rule;

console.log(group.Rule);

I set up an online demo here: http://jsfiddle.net/2YKTX/

And in the console I see:

Object {Id: null, RuleId: null, MatchLogic: 0, Min: null, Max: null…}

answered Apr 22, 2014 at 18:52

vtortola

36.1k33 gold badges169 silver badges270 bronze badges

1 Comment

allencoded Over a year ago

Found what broke it Object was empty not null

Collectives™ on Stack Overflow

Push a Object onto another Javascript object [duplicate]

2 Answers 2

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Linked

Related