Rails Rspec Testing Controller New Action

Question

I am trying to test the new action in my controller. At the moment it looks like this:

Controller

def new
  @business = Business.new
  @business.addresses.build
end

Spec

describe 'GET #new' do
  it 'assigns a new business to @business' do
    get :new
    expect(assigns(:business)).to be_a_new(Business)

  end
end

I would like to test the line '@business.addresses.build'. How do I do this?

Thanks in advance!

Try to check presence of @business.addresses stackoverflow.com/questions/6084346/… — Stepan Zakharov
– Stepan Zakharov, Commented Apr 30, 2014 at 12:12

SteveTurczyn · Accepted Answer · 2014-05-02 02:59:57Z

12

How about

expect(assigns(:business).addresses.first).to be_a_new(Address)

answered May 2, 2014 at 2:59

SteveTurczyn

37k6 gold badges46 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

maaachine · Accepted Answer · 2014-05-02 04:27:23Z

1

Assuming build is a method, you only need test to ensure that build is called. You could do so by replacing the new Business with a mock that has an addresses attribute that expects to receive :build.

I haven't tested this, but I suspect you could do something like:

business = double('business')
addresses = double('addresses')
business.should_receive(:addresses).and_return(addresses)
addresses.should_receive(:build)
Business.stub(:new).and_return(business)

edited May 2, 2014 at 4:27

answered May 2, 2014 at 4:18

maaachine

8211 gold badge7 silver badges12 bronze badges

4 Comments

sevenseacat Over a year ago

I wouldn't do this, because it's testing implementation rather than result. What if you changed build to be new? The result is the same, but your test would break.

maaachine Over a year ago

That's true! It's a very brittle test, but he did ask how to test that specific line. Perhaps the bigger question is why that line is even in the controller. Should it be moved to the constructor?

Rj01 Over a year ago

Sorry, I am new to rails. I understand what a constructor is however not sure where it should be implemented using the mvc pattern. Would it be put in the model and called from the controller?

maaachine Over a year ago

Inside your definition for Business, you can define a function called initialize that acts as the endpoint for Business.new(...). In your case, it might contain addresses.build if you know that all business instances should build addresses.

Collectives™ on Stack Overflow

Rails Rspec Testing Controller New Action

2 Answers 2

Comments

4 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related