Setting routing for different forms on different tabs in the same view

Question

I'm in need of some help regarding setting up the routing (I think that is the problem) for a view that is set up with bootstrap tabbed navigation. What I want to do is set up a form in each tab. Sounds easy enough.

However I can't figure out how the routing works when you want to submit two different actions (one to save to the db, and the other to get info from the db), each from their own tab. I can get it all to work perfectly if I give the "get_users" controller action a view, but when I try to bring it back together on the same page, just in different tabs, it goes a little awry and I'm not sure how to route correctly.

The two controller actions I have are:

class Users::RegistrationsController < Devise::RegistrationsController

    def user_accounts
        @user = User.new
    end

    def get_users
        @users = User.search(params[:search]).paginate
                (:per_page => 20, :page => params[:page] )
    end
end

EDIT ------------------------------------

Include routes.rb - excluding the extra devise related routes. Can get the create_internal_user action working not the other. I understand that the routes are incorrect as rails could never understand them. The first is correct, the second is simply what I would imagine it to look like if it were possible

# Authentication
as :user do

#add new internal users
get '/useraccounts' => 'users/registrations#user_accounts', as: 'new_internal_user'
post '/useraccounts' => 'users/registrations#create_internal_user', as: 'internal_user'

**# searching users - this is where I am uncertain**
get '/useraccounts' => 'users/registrations#get_users', as: 'get_internal_user'
post '/useraccounts' => 'users/registrations#get_users', as: 'getting_internal_user'

# other devise routes here

end

The view that renders them looks like this and renders two partials:

    <div class="container">
     <h1>User Accounts</h1>
     <ul class="nav nav-tabs">
      <li class="active"><a href="#adduser" data-toggle="tab">Add User</a></li>
      <li><a href="#getusers" data-toggle="tab">Edit User</a></li>
     </ul>
     <!-- Tab panes -->
     <div class="tab-content">
      <div class="tab-pane fade in active" id="adduser">
       <%= render 'users/registrations/create_internal' %>
     </div>
      <div class="tab-pane fade in" id="getusers">
       <%= render 'users/registrations/get_users' %>
     </div>
    </div>
   </div>

The two partials

_create_internal.html.erb

    <%= form_for(resource, as: resource_name, 
                 url: new_internal_user_path(resource_name)) do |f| %>
      <div><%= f.label :email %><br />
    <% for role in User::ROLES %>
        <%= check_box_tag "user[roles][#{role}]", role, 
                        @user.roles.include?(role), 
                        {:name => "user[roles][]"}%>

        <%= label_tag "user_roles_#{role}", role.humanize %><br />
    <% end %>
    <%= hidden_field_tag "user[roles][]", "" %>
    <div class="col-md-10 center"><%= f.submit "Create User", 
                 class: "btn btn-primary"%></div>
<% end %>

_get_users.html.erb

  <%= form_tag({:controller => "users/registrations", :action => "get_users"},
                method: :get) do %>    
<p>  
  <%= text_field_tag :search, params[:search] %>  
  <%= submit_tag "Search", :name => nil %>  
</p>
  <% end %>
  <div class="center" id="users">
  <%  if defined?(@users) %>
  <%= render 'users/registrations/searchresults' %></div>
  <%=  will_paginate @users %> 
<% end %>

I've spent many many hours trying to figure this out and just haven't been able to. Very new to Rails so this may be an easy question for someone. I've had a look at using AJAX, and resourceful routing, but as I'm still new I'm finding it a bit tough to wrap my head around it all at the one time. This is my first post on SO so apologies if I'm missing anything (please let me know).

If I understand you correctly, you want a rout that maps to def get_users end and another that maps to def create_internal_user end. is that correct? — Wally Ali
– Wally Ali, Commented May 6, 2014 at 6:12
@WaliAli Yes, that's correct. However my confusion is that I want to be able to go to /useraccounts, click on one tab and the submit to call create_internal_user and then click on the other tab and the submit to call get_users. I will update now to include routes.rb — twiggy
– twiggy, Commented May 6, 2014 at 6:21
get '/useraccounts' => 'users/registrations#get_users', as: 'get_internal_user' to find out which action this route is pointing to, do localhost:3000/rails/info then on the right most column look under Controller#Action — Wally Ali
– Wally Ali, Commented May 6, 2014 at 6:33
what's your controller's name? the format is controller_name#action_name — Wally Ali
– Wally Ali, Commented May 6, 2014 at 6:37

Wally Ali · Accepted Answer · 2014-05-06 06:49:15Z

0

Let's say your controller is UsersController and assuming your routes are not nested, this is how you create named routes:

get '/useraccounts', to: 'users#get_users' ## this route maps to the get_users action 

post '/useraccounts' to: 'users#create_internal_user'  # this route maps to the create_internal_user action

EDIT: the format is controller_name#action_name. So make sure to replace users with your controllers name in plural

UPDATE:

if your controller's name is RegistrationsController

try:

 get '/useraccounts', to: 'registrations#get_users'

post '/useraccounts' to: 'registrations#create_internal_user'

edited May 6, 2014 at 6:49

answered May 6, 2014 at 6:22

Wally Ali

2,5081 gold badge15 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

twiggy Over a year ago

if my understanding of the rails framework is correct this will only work if there is a get_users view. Get_users is actually a partial rendered in /useraccounts. Therefore I get a template missing error with this code.

Wally Ali Over a year ago

I couldn't see your controller's name from your question. so is your controller's name UserAccountsController ?

twiggy Over a year ago

Controller name is 'RegistrationsController'. I overrode the standard Devise Registrations controller to create a new create action named 'create_internal_user' in addition to the standard 'create' offered by the devise controller.

twiggy Over a year ago

Thanks for your suggestion Wali however in the question post I had tried this in my routes. The issue comes about because of the tabbed navigation and the multiple forms that come as partials.

Richard Peck · Accepted Answer · 2014-05-06 09:05:45Z

0

Looking at it, I think your error will likely be from your _get_users.html.erb partial.

Firstly, you're using form_for - why? Your use of form_for basically means you have to use the data inside @user to make it work, which I think will be causing the problem

I would use a form_tag as this does not persist your data:

<%= form_tag({:controller => "users/registrations", :action => "get_users"}, method: :get) do %>   
  <%= text_field_tag :search, params[:search] %>  
  <%= submit_tag "Search", :name => nil %>  
<% end %>

<%  if defined?(@users) #-> this might need to be passed as a local var %>
  <%= render 'users/registrations/searchresults' %></div>
  <%=  will_paginate @users %> 
<% end %>

Routes

Your other problem is to do with your routes:

get '/useraccounts' => 'users/registrations#user_accounts', as: 'new_internal_user'
post '/useraccounts' => 'users/registrations#create_internal_user', as: 'internal_user'

**# searching users - this is where I am uncertain**
get '/useraccounts' => 'users/registrations#get_users', as: 'get_internal_user'
post '/useraccounts' => 'users/registrations#get_users', as: 'getting_internal_user'

Tell me how you expect Rails to know the difference between get '/useraccounts and get /useraccounts? The fact is it can't

You'll need to split up the routes so they don't all use the same path. I would do this:

get '/useraccounts' => 'users/registrations#user_accounts', as: 'new_internal_user'
post '/useraccounts' => 'users/registrations#create_internal_user', as: 'internal_user'

**# searching users - this is where I am uncertain**
get '/search' => 'users/registrations#get_users', as: 'get_internal_user'

edited May 6, 2014 at 9:05

answered May 6, 2014 at 7:14

Richard Peck

76.8k9 gold badges98 silver badges148 bronze badges

11 Comments

twiggy Over a year ago

Okay I tried your suggestion - needed to add '(' around the curly braces to get it to pass syntax errors. However it still tries to do the 'create_internal_user' action when I submit the form in '_get_users'. Thanks for the little bit of learning on form_tag vs. form_for

Richard Peck Over a year ago

Thanks for reply! Okay you're getting a problem with it routing to create_internal_user. This is because the form will be sending a post request -- we need to add method: : get for you (see updated answer)

twiggy Over a year ago

So we have successfully removed any runtime errors or syntax errors, however it is still not hitting the correct action in the controller unfortunately. What I'm seeing in the log outputs is 'Started GET "/useraccounts?utf8=%E2%9C%93&search=test"' ... 'Processing by Users::RegistrationsController#user_accounts as HTML'. So as you can see it is still hitting the other controller actions from user_accounts.

twiggy Over a year ago

Hi Rich, I totally understand what you are saying - and I maybe wasn't clear in my question, as I have previously done what you are suggesting. That is by separating it all out and having a totally new page for the searching function. However my goal is to have both of the the forms (creating and searching) accessible from the original /useraccounts view with them being separated by a tabbed navigation menu. Having them in a tabbed navigation is the issue.

Richard Peck Over a year ago

Okay, I understand I think. But you have to remember that a route & a view are totally different. A route just sends a user to a specific controller / action; a view can have anything you want on there. You are asking about using two forms on the same view - that's great! However, those forms have no bearing on your routes

|

Community · Accepted Answer · 2017-05-23 11:58:44Z

After much frustration I have solved my own problem. With help from Rich Peck I realised that I was essentially creating a view with two forms on it, and that the tabbed navigation didn't really mean anything to the problem.

So I really only needed the two routes:

# #add new internal users
get '/useraccounts' => 'users/registrations#user_accounts', as: 'user_accounts'
post '/useraccounts' => 'users/registrations#create_internal_user', as: 
                                                 'create_internal_user'

And then in the controller just changed the user_accounts action to look like this:

def user_accounts
    @user = User.new
    if params[:search_button]
        @users = User.search(params[:search]).paginate(:per_page => 15, :page => params[:page] )
    end
end

Came about this discovery thanks to this question/answer here: form_for with multiple controller actions for submit

In the end the problem wasn't what I thought it was and ended up being simple. Was certainly an interesting learning journey. Thanks for your help again Rich Peck.

Collectives™ on Stack Overflow

Setting routing for different forms on different tabs in the same view

3 Answers 3

4 Comments

11 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

11 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related