How to make a loop in Jquery continue if undefined

Question

I have a problem, I have made a script that runs through all images and takes the href of the image and puts it to each buy button under the image. Every image has a buy button underneedth.

But when there is an image without a link the script stops and does not continue to the end.

How could I make it continue till the end?

Found somewhere that return non-false; is like continue, but did not work.

Not allowed to put markup sorry.

$('.productImg a').each(function(){
    if($(this).attr('href').indexOf("sometext")> 0 && $(this).attr('href').indexOf("sometext") != 'undefined'){
       $(this).parents(".item").find(".BuyLink a").attr('href',$(this).attr('href'));
    }
    else if ($(this).attr('href').indexOf("sometext") == 'undefined') {
        return non-false;
    }
});

There is no value "non-false". If you return false it breaks, if you return anything else it does not. So I suspect the page you found was saying "return anything which is not false". You could return "foo" if you want. But return true is the best advice. Your code is creating an error because your are returning an undefined variable I suspect. — Adam
– Adam, Commented May 8, 2014 at 10:59
indexOf(...) will never, ever return the string undefined. If the string is not found it returns -1. — lonesomeday
– lonesomeday, Commented May 8, 2014 at 11:00
even, in comparison, if undefined is not string then comparison is wrong, either !== 'undefined' or != undefiend — developerCK
– developerCK, Commented May 8, 2014 at 11:01

mpcabd · Accepted Answer · 2014-05-08 10:59:08Z

1

$('.productImg a').each(function(){
    if (!$(this).attr('href')) // <--- This checks if the image has a link
        return;

    if($(this).attr('href').indexOf("sometext")> 0 && $(this).attr('href').indexOf("sometext") != 'undefined'){
       $(this).parents(".item").find(".BuyLink a").attr('href',$(this).attr('href'));
    }
});

answered May 8, 2014 at 10:59

mpcabd

1,80715 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

vaskort Over a year ago

That was clean bro, thanks. It checks in the beginning if there is not a link and if it doesnt continues to the next one?

mpcabd Over a year ago

Sure, if the current element doesn't have href attribute it will continue the loop.

Collectives™ on Stack Overflow

How to make a loop in Jquery continue if undefined

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related