JavaScript onclick doesn't work except for document.onclick

Question

I've been trying to learn something about JavaScript today, came across events and somehow I'm stuck at it.

When I call the first function it just works, however if I call the second one it doesn't execute the function for some reason? I've tried doing it without the windows.onload event I've tried putting the script code inside head element or just above the closing body tag but nothing has changed, any tips?

function peh() {
    
    document.onclick = function(){
    alert("you clicked");
}
}

function second(){
    var myElement = getElementsByTagName("mImg");
    myElement.onclick = function(){
        alert("clicked img");
    }
}

window.onload = function() {
    second();
}

Cem Demir · Accepted Answer · 2014-05-11 21:17:52Z

1

I guess you have to change your code like that :

function second(){
   var myElement = document.getElementsByTagName("mImg");
   myElement[0].onclick = function(){
    alert("clicked first img");
   }
}

Because getElementsByTagName selector is returning array. And you can make it "for" or "while" loop for each element.

answered May 11, 2014 at 21:17

Cem Demir

1422 silver badges6 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Solo · Accepted Answer · 2014-05-11 21:21:02Z

0

You use getElementsByTagName which receives the DOM HTML tag name, say, 'td' Better use getElementsById, as I guess mImg is an ID of some element...

answered May 11, 2014 at 21:21

Solo

3891 silver badge10 bronze badges

1 Comment

IamLee Over a year ago

yeah, i didn't change that when i copied it here, but it doesn't work with getElementById either

MCHAppy · Accepted Answer · 2014-05-11 21:25:21Z

0

Thanks to jquery framework you will not bother yourself about those things anymore . just use jquery functions .

$(document).ready(function(){
$(mImg).click(function(){
   alert("goood");
 });
});

or for dynamic tags :

$(document).on("click","mImg",function(){
alert("goood");
});

answered May 11, 2014 at 21:25

MCHAppy

1,0029 silver badges15 bronze badges

1 Comment

IamLee Over a year ago

Yeah, I know where you are getting :) The thing is I want to have some basic knowledge and understanding of pure javascript before moving on to jQuery and other frameworks

Collectives™ on Stack Overflow

JavaScript onclick doesn't work except for document.onclick

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related