Calculating an average within a JavaScript function using arguments

Question

I'm trying to define teams with 4 different attributes -- speed, header, power, and accuracy. Then, I want to find the average of theses 4 attributes, but for some reason when I try to do so, or perform any mathematical operation between attributes, the program returns undefined. Any ideas?

team1 = new team ("Manchester United");
team2 = new team ("Arsenal");
team3 = new team ("Chelsea");
team4 = new team ("New York Rangers");

function soccerGame (team1, team2, team3, team4)  {

var team = function(teamName) {
    this.teamName = teamName;
    this.speed = Math.floor(Math.random() * 10) + 1 ; 
    this.header = Math.floor(Math.random() * 10) + 1 ;
    this.power = Math.floor(Math.random() * 10) + 1 ;
    this.accuracy = Math.floor(Math.random() * 10) + 1 ;
    console.log(this.accuracy + this.power + this.header + this.speed) / 4;
};
}

AstroCB · Accepted Answer · 2014-05-12 03:02:39Z

1

Your only issue is that you have your constructor wrapped in soccerGame, making it a local variable. Local variables can only be accessed from within the scope of the function. You have two options: put your team declarations within the soccerGame function, or remove the function and implement what you were planning to do with that somewhere else. You can't pass in teams to it if you define your teams within the function, so I would recommend the second option.

Demo

edited May 12, 2014 at 3:02

answered May 12, 2014 at 2:43

AstroCB

12.4k20 gold badges59 silver badges76 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Qantas 94 Heavy · Accepted Answer · 2014-05-12 04:30:44Z

0

var team = function(teamName) {
    this.teamName = teamName;
    this.speed = Math.floor(Math.random() * 10) + 1 ; 
    this.header = Math.floor(Math.random() * 10) + 1 ;
    this.power = Math.floor(Math.random() * 10) + 1 ;
    this.accuracy = Math.floor(Math.random() * 10) + 1 ;
    console.log(this.accuracy + this.power + this.header + this.speed) / 4;
};


team1 = new team ("Manchester United");
team2 = new team ("Arsenal");
team3 = new team ("Chelsea");
team4 = new team ("New York Rangers");

Your team function and arragement of code does matter.

Working Demo

edited May 12, 2014 at 4:30

Qantas 94 Heavy

16k31 gold badges74 silver badges89 bronze badges

answered May 12, 2014 at 2:41

jhyap

3,8496 gold badges30 silver badges49 bronze badges

3 Comments

RobG Over a year ago

Order only matters because a function expression is being used. If the OP used a function declaration, it wouldn't matter (but would still be better if the function declaration was first).

jhyap Over a year ago

I mean the var team = function(team) should place outside the soccerGame function. That is my meaning of arragement of code.

RobG Over a year ago

Ok. You may have guessed I'm not a fan of using function expressions where function declarations can be used. ;-)

Collectives™ on Stack Overflow

Calculating an average within a JavaScript function using arguments

2 Answers 2

Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related