Should angular.module be set variable on AngularJS

Question

I’ve read two AngularJS sample on Github. I’m confused to how to modularize controller. The first on is set variable(foodMeApp) and re-use it. Controllers need less arguments. It’s easier to read. But, second one doesn’t use variable(foodMeApp) and has more arguments. I think this way is frequently used on AngularJS samples.
Is this any merit to use the second way?

1.https://github.com/IgorMinar/foodme

var foodMeApp = angular.module('foodMeApp', ['ngResource']);

foodMeApp.constant('CONFIG_A', {
  baseUrl: '/databases/',
});

foodMeApp.controller('HogeController', function HogeController($scope, CONFIG_A) {
    console.log(“less arguments");
});

2.https://github.com/angular-app/angular-app

angular.module('foodMeApp', ['ngResource']);

angular.module('foodMeApp').constant('CONFIG_B', {
  baseUrl: '/databases/',
});

angular.module('foodMeApp').controller('HogeController', ['$scope', 'CONFIG_B', function($scope, CONFIG_B) {
    console.log("more arguments");
}]);

mpm · Accepted Answer · 2014-05-22 10:39:32Z

1

since angular.module('...') ,constant,provide,controller,factory ... return the same mdoule you can chain module method calls if you want to or not... it's just javascript.

you can write

angular.module('foo',[])
.controller('bar',function(){})
.service('baz',functinon(){})
.constant('buzz',something)
.value('bizz',somethingelse);

it makes no different.

answered May 22, 2014 at 10:39

mpm

20.2k7 gold badges52 silver badges56 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Chris · Accepted Answer · 2014-05-22 11:50:03Z

This example is using an array for your dependencies which are going to be injected into your controller. The array method is typically used when the code is going to minified at some time and allows angularjs to know exactly which items will be injected. If this array were not there, angular would only see 'a', 'b' as the items injected into the function and would not be able to figure out what those things were. Items in the array are strings and will not be changed when the minification happens.

 angular.module('foodMeApp').controller('HogeController', ['$scope', 'CONFIG_B', 
   function($scope, CONFIG_B) {
        console.log("more arguments");
   }]);

Hope this helps explain the differences which you have seen.

Aniket Sinha · Accepted Answer · 2014-05-22 12:16:58Z

0

There is no such 'merit' of going for 2nd option. 1st approach is more popular as it avoids repeating angular.module('foodMeApp') so many times. If you give it a name "foodMeApp" you can directly use foodMeApp as you would have used in 2nd approach. Less repetition, simpler life.

answered May 22, 2014 at 12:16

Aniket Sinha

6,0316 gold badges39 silver badges50 bronze badges

1 Comment

pkozlowski.opensource Over a year ago

By using the first form you are introducing a global JavaScript variable. So while "simpler" it is not necessarily "right"...

Collectives™ on Stack Overflow

Should angular.module be set variable on AngularJS

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related