Ruby input doesnt works (newbie)

Question

the problem occurs when I put the inputs (n1, n2) and the console still request me for more inputs.

my code:

#!/usr/bin/env ruby

def Euclides(n1,n2)
    while n1 % n2 != 0
        aux = n1
        n1 = n2
        n2 = aux % n2
    end
    return n2
end

n1 = gets
n2 = gets
puts Euclides(n1,n2)

The problem is not with gets, I just tested. Your code is falling infinite loop, thus it seems to you. Just put puts 123 before the loop, you can see that, control goes there. — Arup Rakshit
– Arup Rakshit, Commented May 24, 2014 at 19:03
not is infty loop, try with 2 values in function, like this: puts Euclides(5,10) — Joaco Del Garzo
– Joaco Del Garzo, Commented May 24, 2014 at 19:12

Uri Agassi · Accepted Answer · 2014-05-24 19:50:32Z

1

Your problem is that what you get from gets is a string. Passing two strings to your method results in an infinite loop since string1 % string2 will always return string1 (unless you have some special syntax in that string, see % documentation for string.

To solve you problem, you should convert your strings to integers:

n1 = gets.to_i
n2 = gets.to_i
puts Euclides(n1,n2)

answered May 24, 2014 at 19:50

Uri Agassi

37.5k16 gold badges82 silver badges96 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Ruby input doesnt works (newbie)

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related