Strange undefined jquery error

Question

I am trying to itterate trough a jquery array, and I am having an error The script causing the error is:

$.each(amount, function (key, value) {
    console.info('>>> Selected line: '+value.value + " " + value.currency);
    if ((value.currency == currency) && (value.value == val)) {
        amount.splice(key,1);
        console.info('Deleted: [' + value.value + " " + value.currency+ "] from line "+ key);
    }
});

The error firebug throws is:

TypeError: value is undefined

Could someone point me where the error is or how to fix the error?

[{value: 100, currency: 'EUR'}, {value: 125, currency: 'USD'}] — rosuandreimihai
– rosuandreimihai, Commented May 29, 2014 at 18:07
Did that also, and changed the function (key, value) to function (key, data) but still get the data is undefined — rosuandreimihai
– rosuandreimihai, Commented May 29, 2014 at 18:09

Jason P · Accepted Answer · 2014-05-29 18:17:16Z

1

The issue is with your .splice(). When you remove item 0, everything moves up a spot, so you no longer have an item 1.

Generally speaking, you can't remove items from a list you're enumerating (unless taking steps to adjust the current index when adding or removing items, but.. yuck).

I would recommend using a filter function like grep instead:

http://jsfiddle.net/DnN4a/

var newArr = $.grep(amount, function(item, idx) {
   return item.currency == currency || item.value == val; 
}, true);

answered May 29, 2014 at 18:17

Jason P

27k3 gold badges34 silver badges45 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

rosuandreimihai Over a year ago

Thank you! I thaught that it could be related to changing the array, but had no clue about how to avoid splice

Collectives™ on Stack Overflow

Strange undefined jquery error

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related