Django Update Object in Database

Question

I'm trying to run a simple update form that should update all object values in DB submitted from the form.

This is my update view that does nothing other than redirecting to the "/". No errors but no update either.

def update(request, business_id):
    if request.method == 'POST':
        form = BusinessForm(request.POST)

        if form.is_valid():
            t = Business.objects.get(id=business_id)
            t.save()
        return HttpResponseRedirect("/")
    else:
          ...

alecxe · Accepted Answer · 2014-05-30 16:35:00Z

2

You are not updating any fields, use form.cleaned_data to get the form field values:

Once is_valid() returns True, the successfully validated form data will be in the form.cleaned_data dictionary. This data will have been converted nicely into Python types for you.

if form.is_valid():
    t = Business.objects.get(id=business_id)
    t.my_field = form.cleaned_data['my_field']
    t.save()

Also, consider using an UpdateView class-based generic view instead of a function-based:

A view that displays a form for editing an existing object, redisplaying the form with validation errors (if there are any) and saving changes to the object. This uses a form automatically generated from the object’s model class (unless a form class is manually specified).

edited May 30, 2014 at 16:35

answered May 30, 2014 at 16:28

alecxe

476k127 gold badges1.1k silver badges1.2k bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

WayBehind Over a year ago

Thanks! Thats what I thought, I just wasnt sure if Django is smart enough to grab all the values from the form as it is done with saving new data or if I have to define each field.

alecxe Over a year ago

@WayBehind django is smart enough if you would use an UpdateView - I've also updated the answer. Hope that helps.

WayBehind Over a year ago

Thanks for the update. I wasnt aware of the UpdateView and will look into that!

Collectives™ on Stack Overflow

Django Update Object in Database

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related