Despite `addObject` , NSMutableArray.count is 1

Question

After adding four _labelView by -addLabel, I'd like to move all _labelView at random by -moveLabel.
LabelView is subclass of UIView.

But in case of this code, I can move only one _labelView I have added at the last.
Looking NSLog(@"%d", _viewsArray.count), it outputs "1".
How do I fix it to move all _labelView?

enter image description here

@property (nonatomic, strong) LabelView* labelView;
@property (nonatomic, strong) NSMutableArray* viewsArray;

- (void)addLabel
{
    _viewsArray = [[NSMutableArray alloc]init];
    _labelView = [[LabelView alloc]initWithFrame:CGRectMake(0, 0, 200, 25)];
    [_viewsArray addObject:_labelView];
    for (_labelView in _viewsArray){
        [self.view addSubview:_labelView];
    }
    NSLog(@"%d", _viewsArray.count);
}

- (void)moveLabel
{
    int n;
    CGPoint labelFrame;
    for (_labelView in _viewsArray)
    {
        n = arc4random() % 4;
        switch (n) {
            case 0: labelFrame = CGPointMake(30, 50);
                break;
            case 1: labelFrame = CGPointMake(30, 100);
                break;
            case 2: labelFrame = CGPointMake(30, 150);
                break;
            case 3: labelFrame = CGPointMake(30, 200);
                break;
            default:
                break;
        }
        [UIView animateWithDuration:0.5f delay:0.0f options:UIViewAnimationCurveEaseIn
                         animations:^{_labelView.center = labelFrame;} completion:^(BOOL finished){}];
    }
    NSLog(@"%d", _viewsArray.count);
}

whenever you call addLabelyou are creating a new empty mutable array... — Volker
– Volker, Commented Jun 2, 2014 at 14:39
Moreover, after you fix that problem, the addLabel code will re-add all of it's labels to self.view. Don't loop that array on the add. — danh
– danh, Commented Jun 2, 2014 at 14:41

Greg · Accepted Answer · 2014-06-02 14:39:25Z

4

In your addLabel method you allocate the NSMutableArray every single time you add new label:

_viewsArray = [[NSMutableArray alloc]init];

so you will have just one object in that array. Simple move this line to viewDidLoad method (or some init method if it;s not view controller subclass) and it should fix it.

answered Jun 2, 2014 at 14:39

Greg

25.5k7 gold badges56 silver badges66 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

MeXx · Accepted Answer · 2014-06-02 14:39:18Z

0

You are allocating a new _viewsArray everytime addView is called! You should rather allocate the Array at viewDidLoad or something, and then just use it

answered Jun 2, 2014 at 14:39

MeXx

3,36527 silver badges39 bronze badges

Comments

Sulthan · Accepted Answer · 2014-06-02 14:40:01Z

0

The most simple fix...

- (void)addLabel {
    if (_viewsArray == nil) {
        _viewsArray = [[NSMutableArray alloc] init];
    }

answered Jun 2, 2014 at 14:40

Sulthan

130k23 gold badges223 silver badges277 bronze badges

Collectives™ on Stack Overflow

Despite `addObject` , NSMutableArray.count is 1

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related